Better solution needed for "Compilation errors on restricted classes"

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 0.9.7
  • Fix Version/s: None
  • Component/s: Project Configuration
  • Labels:
    None

Description

The current recommended solution (http://docs.codehaus.org/display/M2ECLIPSE/Project+FAQ#ProjectFAQ-Compilationerrorsonrestrictedclasses) to hide the Access REstriction may mask other issues. We have found switching the order in the Window --> Preferences --> Java Build Path --> Order and Export to put the Maven Dependecies Classpath Container ahead of the JRE System Library. Wouldn't it be possible for the ProjectConfiguration to make sure the Maven Dependencies Classpath Container is list first?

  1. Text File
    MNGEclipse-1218.patch
    26/Feb/09 12:21 PM
    2 kB
    Timothy G. Rundle
  2. Text File
    MNGEclipse-1218withExampleAndExistingTestFix.patch
    27/Feb/09 1:31 PM
    7 kB
    Timothy G. Rundle

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. MNGECLIPSE-1044 Create JRE system libraries with no access rules

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Timothy G. Rundle added a comment -

Here is a patch that resolves the issue. To reproduce the issue you need the following setup:

1) JDK 1.6 installed
2) maven-compiler-plugin set to 1.5
3) depedency on jaxb or jaxws

Show
Timothy G. Rundle added a comment - Here is a patch that resolves the issue. To reproduce the issue you need the following setup: 1) JDK 1.6 installed 2) maven-compiler-plugin set to 1.5 3) depedency on jaxb or jaxws
Hide
Permalink
Eugene Kuleshov added a comment -

Timothy, can you please add the test project that would allow to reproduce? Also, I am pretty certain, if you change order of classpaht containers, several existing tests are going to break. Can you please address that in your patch and maybe also add test to verify your use case. See http://docs.codehaus.org/display/M2ECLIPSE/Developer+Guide#DeveloperGuide-Runningtests

Show
Eugene Kuleshov added a comment - Timothy, can you please add the test project that would allow to reproduce? Also, I am pretty certain, if you change order of classpaht containers, several existing tests are going to break. Can you please address that in your patch and maybe also add test to verify your use case. See http://docs.codehaus.org/display/M2ECLIPSE/Developer+Guide#DeveloperGuide-Runningtests
Hide
Permalink
Timothy G. Rundle added a comment -

Here is the requested patch with example and fixes for the test that fails with the change. I did run the unites test before and after the proposed fix and only found one existing unit test that failed. It did not appear the test really needed to have the JRE CPE before the MAVEN CPE, it was just asserting the order. So I corrected the assertions to expect the Maven CPE first then the JRE CPE. That fix is included in attached patch.

Show
Timothy G. Rundle added a comment - Here is the requested patch with example and fixes for the test that fails with the change. I did run the unites test before and after the proposed fix and only found one existing unit test that failed. It did not appear the test really needed to have the JRE CPE before the MAVEN CPE, it was just asserting the order. So I corrected the assertions to expect the Maven CPE first then the JRE CPE. That fix is included in attached patch.

People

  • Assignee:
    Unassigned
    Reporter:
    Timothy G. Rundle
Vote (1)
Watch (1)

Dates

  • Created:
    Updated: