[#MNG-868] Use uniform format for <properties> and other tags - jira.codehaus.org

Maven 2 & 3

Use uniform format for <properties> and other tags

Created: 12/Sep/05 09:02 AM Updated: 13/Dec/08 06:35 PM

Component/s:

Design, Patterns & Best Practices

Affects Version/s:

2.0-beta-1

Fix Version/s:

3.x (to be reviewed)

Time Tracking:

Original Estimate:

2 hours

Remaining Estimate:

2 hours

Time Spent:

Not Specified

Complexity:

Expert

Description

« Hide

In settings.xml, the activationproperties have the format: <property><name/><value/></property>
whereas the 'user' properties below (which don't have any documentation) have the format
<my.property.name>my.property.value</my.property.name>.

They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.

There are more places where duplicate classes are used (repositories,..).

(Also suggest to remove the <dependencies> tag from <dependencyManagement>
and make DependencyManagement extend from Dependencies (or, make it a list)., but this
could prove troublesome.)

Sort Order:

[ Permalink | « Hide ]

Brett Porter added a comment - 12/Sep/05 10:12 AM

no more changes for beta-1

[ Permalink | « Hide ]

John Casey added a comment - 28/Sep/05 11:26 AM

this would require a change to the .mdo files, which isn't going to happen until post-2.0-final, especially since it's not a bug.

We'll revisit syntax for 2.1, and apply lessons learned from 2.0 then.

[ Permalink | « Hide ]

Brett Porter added a comment - 28/Sep/05 07:38 PM

I haven't looked closely, but I think that this should be fixed while we still have the opportunity to do it. Otherwise we need to perpetually support it...

[ Permalink | « Hide ]

John Casey added a comment - 30/Sep/05 09:19 AM

The activation property is not the same as any old configuration parameter. For one thing, we're not (currently) supporting combinatorial logic for multiple properties, which means that using a flat MAP style is leaving the door open to problems of multiple property specification. Perhaps I'd better rename the activation property to <systemProperty>, where the separation is more clear.

In all other cases, properties are a map, or a DOM. In this case, I want the semantics to clearly support one property specification.

[ Permalink | « Hide ]

Maven Developers List added a comment - 05/Jan/06 09:24 PM

John, with your above comment then is this issue pretty much closed?

[ Permalink | « Hide ]

John Didion added a comment - 24/Jan/06 06:15 PM

This is also an issue for plugins that use properties. The plugin documentation states:

Properties

This category covers any map which implements java.util.Properties. These parameters are configured by including XML tags in the form <key>value</key> in the parameter configuration.

However, properties are actually configured using the <property><name/><value/></property> format.