Maven 2 & 3

Use uniform format for <properties> and other tags

Details

  • Complexity:
    Expert
  • Number of attachments :
    0

Description

In settings.xml, the activationproperties have the format: <property><name/><value/></property>
whereas the 'user' properties below (which don't have any documentation) have the format
<my.property.name>my.property.value</my.property.name>.

They should really be uniform. My personal favourite is ofcourse: <property name="....">....</property>.

There are more places where duplicate classes are used (repositories,..).

(Also suggest to remove the <dependencies> tag from <dependencyManagement>
and make DependencyManagement extend from Dependencies (or, make it a list)., but this
could prove troublesome.)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

no more changes for beta-1

Show
Brett Porter added a comment - no more changes for beta-1
Hide
Permalink
John Casey added a comment -

this would require a change to the .mdo files, which isn't going to happen until post-2.0-final, especially since it's not a bug.

We'll revisit syntax for 2.1, and apply lessons learned from 2.0 then.

Show
John Casey added a comment - this would require a change to the .mdo files, which isn't going to happen until post-2.0-final, especially since it's not a bug. We'll revisit syntax for 2.1, and apply lessons learned from 2.0 then.
Hide
Permalink
Brett Porter added a comment -

I haven't looked closely, but I think that this should be fixed while we still have the opportunity to do it. Otherwise we need to perpetually support it...

Show
Brett Porter added a comment - I haven't looked closely, but I think that this should be fixed while we still have the opportunity to do it. Otherwise we need to perpetually support it...
Hide
Permalink
John Casey added a comment -

The activation property is not the same as any old configuration parameter. For one thing, we're not (currently) supporting combinatorial logic for multiple properties, which means that using a flat MAP style is leaving the door open to problems of multiple property specification. Perhaps I'd better rename the activation property to <systemProperty>, where the separation is more clear.

In all other cases, properties are a map, or a DOM. In this case, I want the semantics to clearly support one property specification.

Show
John Casey added a comment - The activation property is not the same as any old configuration parameter. For one thing, we're not (currently) supporting combinatorial logic for multiple properties, which means that using a flat MAP style is leaving the door open to problems of multiple property specification. Perhaps I'd better rename the activation property to <systemProperty>, where the separation is more clear. In all other cases, properties are a map, or a DOM. In this case, I want the semantics to clearly support one property specification.
Hide
Permalink
Maven Developers List added a comment -

John, with your above comment then is this issue pretty much closed?

Show
Maven Developers List added a comment - John, with your above comment then is this issue pretty much closed?
Hide
Permalink
John Didion added a comment -

This is also an issue for plugins that use properties. The plugin documentation states:

Properties

This category covers any map which implements java.util.Properties. These parameters are configured by including XML tags in the form <key>value</key> in the parameter configuration.

However, properties are actually configured using the <property><name/><value/></property> format.

Show
John Didion added a comment - This is also an issue for plugins that use properties. The plugin documentation states: Properties This category covers any map which implements java.util.Properties. These parameters are configured by including XML tags in the form <key>value</key> in the parameter configuration. However, properties are actually configured using the <property><name/><value/></property> format.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:

Time Tracking

Estimated:
2h
Original Estimate - 2 hours
Remaining:
2h
Remaining Estimate - 2 hours
Logged:
Not Specified
Time Spent - Not Specified
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.