Maven 2 & 3

review plugins use of expression and change to default-value/component where appropriate

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0.5
  • Component/s: None
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

we also need a good explanation written down of the difference.

  • default-value is used when expression is null
  • expression is intended to be used to get the user's override, eg from a system property

Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.

Activity

Hide
Allan Ramirez added a comment -

From the clover plugin, I found the usage of expression to be
/**

  • @parameter expression=""
    */
    private String licenseFile;

Since expression value is null, I removed the expression word to be like this
/**

  • @parameter
    */
    private String licenseFile;
Show
Allan Ramirez added a comment - From the clover plugin, I found the usage of expression to be /**
  • @parameter expression="" */ private String licenseFile;
Since expression value is null, I removed the expression word to be like this /**
  • @parameter */ private String licenseFile;
Hide
Brett Porter added a comment -

applied patch

Show
Brett Porter added a comment - applied patch
Hide
Vincent Siveton added a comment -

Patch already applied (r312878)

Show
Vincent Siveton added a comment - Patch already applied (r312878)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
2h
Original Estimate - 2 hours Original Estimate - 2 hours
Remaining:
0m
Remaining Estimate - 0 minutes
Logged:
2h 20m
Time Spent - 2 hours, 20 minutes