Maven 2 & 3

Inconsistent order of repositories and pluginRepositories from profiles in settings (regression Maven 3)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.0.3, 3.0.4
  • Fix Version/s: 3.1.0-alpha-1
  • Component/s: Settings
  • Labels:
    None
  • Environment:
    Mac OS 10.7 and Windows XP
    Java 1.6.0
  • Complexity:
    Intermediate
  • Number of attachments :
    3

Description

Repositories and pluginRepositories defined in profiles in settings.xml are not order consistently. This is a regression compared to Maven 2.

Scenario:

  • Settings.xml defines two profiles, A and B (in this order).
  • Both profiles define a repository and a pluginRepository, A-repo/A-pluginrepo and B-repo/B-pluginrepo respectively.

When checking the effective pom (help:effective-pom) the resulting list of repositories and pluginRepositories shows that they are not ordered consistently. The order is B-repo, A-repo and A-pluginrepo, B-pluginrepo respectively. With Maven 2.2.1 they are ordered consistently (and what I argue is correct): B-repo, A-repo and B-pluginrepo, A-pluginrepo.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anders Hammar added a comment -

Attached IT patch showing this issue. The test case has been marked to execute on all Maven versions and is expected to fail with Maven 3 (tested with 3.0.3 and 3.0.4), but will succeed with Maven 2 (tested with 2.2.1). The patch file doesn't contain a binary test file (fake-maven-plugin.jar), that needs to be added to the "mng-5280/fake-maven-plugin" folder separately.

Show
Anders Hammar added a comment - Attached IT patch showing this issue. The test case has been marked to execute on all Maven versions and is expected to fail with Maven 3 (tested with 3.0.3 and 3.0.4), but will succeed with Maven 2 (tested with 2.2.1). The patch file doesn't contain a binary test file (fake-maven-plugin.jar), that needs to be added to the "mng-5280/fake-maven-plugin" folder separately.
Anders Hammar made changes -
Field Original Value New Value
Attachment MNG-5280-IT.patch [ 60021 ]
Attachment fake-maven-plugin-1.0.jar [ 60022 ]
Hide
Permalink
Anders Hammar added a comment -

Root cause located in org.apache.maven.model.merge.MavenModelMerger, which specifies different behavior for merging repositories than for merging pluginRepositories. Why is the mergeModelBase_Repositories method overriden, but not the mergeModelBase_PluginRepositories method?

Show
Anders Hammar added a comment - Root cause located in org.apache.maven.model.merge.MavenModelMerger, which specifies different behavior for merging repositories than for merging pluginRepositories. Why is the mergeModelBase_Repositories method overriden, but not the mergeModelBase_PluginRepositories method?
Hide
Permalink
Anders Hammar added a comment -

Attached patch fixing issue in maven-model-builder.

Show
Anders Hammar added a comment - Attached patch fixing issue in maven-model-builder.
Anders Hammar made changes -
Attachment MNG-5280-maven-model-builder.patch [ 60039 ]
Hide
Permalink
Stephen Connolly added a comment -

Integration test added to core it suite in r1373759

Show
Stephen Connolly added a comment - Integration test added to core it suite in r1373759
Hide
Permalink
Stephen Connolly added a comment -

r1373761

Show
Stephen Connolly added a comment - r1373761
Stephen Connolly made changes -
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 3.0.5 [ 18129 ]
Resolution Fixed [ 1 ]
Jason van Zyl made changes -
Fix Version/s 3.1.0 [ 18967 ]
Fix Version/s 3.1.x [ 18129 ]
Jason van Zyl made changes -
Fix Version/s 3.1.x [ 18129 ]
Fix Version/s 3.1.0 [ 18967 ]
Herve Boutemy made changes -
Fix Version/s 3.1.0-alpha-1 [ 18967 ]
Fix Version/s 3.1.x [ 18129 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Anders Hammar
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: