Maven 2 & 3

REGRESSION: Injected Settings in a Mojo are missing the profiles from settings.xml

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.0.3
  • Fix Version/s: 3.0.4
  • Component/s: Settings
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

If you have a Mojo with 

/**
 * @parameter expression="${settings}"
 * @required
 * @readonly
 */
private Settings settings;

In Maven 2.2.1, the Settings included all the profiles, in Maven 3.0.3 the profiles are all missing.

This issue becomes critical, as most users using Maven Release Plugin will be storing their gpg.passphrase as a property in a profile in their settings.xml, and as of Maven Release Plugin 2.2.2 we serialize the injected Settings to a file with the result that most users will be unable to use Maven 3.0.3 with Maven Release Plugin 2.2.2

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-724 Release plugin doesn't honor profiles defined in user settings

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-5036 Settings.getProfiles() returning an empty list

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-577 release:prepare does not pass argument "--settings" with current settings.xml to inner maven

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-724 Release plugin doesn't honor profiles defined in user settings

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-756 release:prepare ignores properties from settings.xml

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Stephen Connolly added a comment -

r1226842 contains the fix... needs test case before I am willing to mark this as closed

Show
Stephen Connolly added a comment - r1226842 contains the fix... needs test case before I am willing to mark this as closed
Hide
Permalink
Olivier Lamy added a comment -

merged in 3.0.4RC branch
core it test added

Show
Olivier Lamy added a comment - merged in 3.0.4RC branch core it test added

People

  • Assignee:
    Unassigned
    Reporter:
    Stephen Connolly
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: