Maven 2 & 3

ModelMerger omits relativ path

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.0.3
  • Fix Version/s: 3.0.4
  • Component/s: General
  • Labels:
    None
  • Complexity:
    Intermediate
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

ModelMerger omits relativ path when source is not dominat, because of fiel Parent#relativePath will be initialized with "../pom.xml" on instanciation.

new ModelMerger().merge(target, source, false, null); // merge with sourceDominant = false

Attached test case.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Bentmann added a comment -

Keeping the target value is the very purpose of sourceDominant=false.

Show
Benjamin Bentmann added a comment - Keeping the target value is the very purpose of sourceDominant=false.
Hide
Permalink
Bernd Vogt added a comment -

Pleas take a look at the unit test.

The target models parent reference is null and the source model contains a fully configured parent object (groupId, artifactId, version and relativPath is set). After merging it with sourceDominant = false the target models parent isn't null any more and its attributes are set with the source models attributes except the relativPath. This doesn't makes sense in any case ..

Show
Bernd Vogt added a comment - Pleas take a look at the unit test. The target models parent reference is null and the source model contains a fully configured parent object (groupId, artifactId, version and relativPath is set). After merging it with sourceDominant = false the target models parent isn't null any more and its attributes are set with the source models attributes except the relativPath . This doesn't makes sense in any case ..
Hide
Permalink
Benjamin Bentmann added a comment -

Oh, got it, fixed in r1156671.

Show
Benjamin Bentmann added a comment - Oh, got it, fixed in r1156671 .

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Bernd Vogt
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: