Maven 2 & 3

mvn -nsu (--no-snapshot-updates) should not download snapshots (and break local builds)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 3.0.3
  • Fix Version/s: 3.0.4
  • Component/s: Command Line
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

Here's the command I ran (on a fresh morning, because our update policy is daily and our SNAPSHOTs are deployed by Hudson at night, with maven 3.0.3):

$ mvn -nsu clean install -DskipTests
[INFO] Scanning for projects...
Downloading: http://repository.jboss.org/nexus/content/groups/public/org/drools/droolsjbpm-parent/5.2.0-SNAPSHOT/maven-metadata.xml
...
[INFO] ------------------------------------------------------------------------
[INFO] Building Drools Planner core 5.2.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
Downloading: http://repository.jboss.org/nexus/content/groups/public/org/drools/knowledge-api/5.2.0-SNAPSHOT/maven-metadata.xml
Downloaded: http://repository.jboss.org/nexus/content/groups/public/org/drools/knowledge-api/5.2.0-SNAPSHOT/maven-metadata.xml (2 KB at 1.8 KB/sec)
Downloading: http://repository.jboss.org/nexus/content/groups/public/org/drools/knowledge-api/5.2.0-SNAPSHOT/knowledge-api-5.2.0-20110413.010206-9.pom
Downloaded: http://repository.jboss.org/nexus/content/groups/public/org/drools/knowledge-api/5.2.0-SNAPSHOT/knowledge-api-5.2.0-20110413.010206-9.pom (6 KB at 6.0 KB/sec)
...
Downloading: http://repository.jboss.org/nexus/content/groups/public/org/drools/knowledge-api/5.2.0-SNAPSHOT/knowledge-api-5.2.0-20110413.010206-9.jar
...

Despite that I added "nsu" (also known as "-no-snapshot-updates"), it downloaded snapshots.

This is a pretty bad thing, because if I hadn't pulled in days (and just wanted to test my local changes before merging in remote changes),
this would have broke my build, for example:

  • because the parent pom in downloaded SNAPSHOT had a dependency removed which my local pom was still using (because I hadn't pulled the changes yet)
  • because the downloaded knowledge-api changed a non-released method signature (and I hadn't pulled the changes to deal with that yet).
  • ...

Issue Links

is related to

New Feature - A new feature of the product, which has yet to be developed. MNG-2681 Add cli flag to set all snapshot repos to updatePolicy = never

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benson Margulies added a comment -

I just added an integration test to maven that does the right thing (doesn't download snapshots). It passes.

Perhaps you could offer some additional thought as to what might be going on here?

Show
Benson Margulies added a comment - I just added an integration test to maven that does the right thing (doesn't download snapshots). It passes. Perhaps you could offer some additional thought as to what might be going on here?
Hide
Permalink
Benson Margulies added a comment -

/Users/benson/asf/mvn/core-integration-testing/core-it-suite svn log -r1140365
------------------------------------------------------------------------
r1140365 | bimargulies | 2011-06-27 19:17:28 -0400 (Mon, 27 Jun 2011) | 2 lines

MNG-5064: add a test that seems to prove that this problem does not, in fact, exist.

Show
Benson Margulies added a comment - /Users/benson/asf/mvn/core-integration-testing/core-it-suite svn log -r1140365 ------------------------------------------------------------------------ r1140365 | bimargulies | 2011-06-27 19:17:28 -0400 (Mon, 27 Jun 2011) | 2 lines MNG-5064 : add a test that seems to prove that this problem does not, in fact, exist.
Hide
Permalink
Geoffrey De Smet added a comment -

Yet I have replicated it a couple of days on the command line. Strange.
Maybe, there's a difference between the command line and the test environment?

I am using maven 3.0.3.

Here's a replication of what I did (although there's might be a shorter reproduce recipe):

// Use maven 3.0.3 on linux

$ git clone git@github.com:droolsjbpm/droolsjbpm-build-bootstrap.git

// clones droolsjbpm-knowledge, then drools, then drools-planner, ...
$ droolsjbpm-build-bootstrap/script/git-clone-others.sh

// builds droolsjbpm-knowledge, then drools, then drools-planner, ...
$ droolsjbpm-build-bootstrap/script/mvn-all.sh clean install -DskipTests

// Note: drools-planner depends on a SNAPSHOT of drools

// Wait one day

$ cd drools-planner
$ mvn clean install -nsu -DskipTests
// It downloads drools-20110727-... pom and jar
Show
Geoffrey De Smet added a comment - Yet I have replicated it a couple of days on the command line. Strange. Maybe, there's a difference between the command line and the test environment? I am using maven 3.0.3. Here's a replication of what I did (although there's might be a shorter reproduce recipe): // Use maven 3.0.3 on linux $ git clone git@github.com:droolsjbpm/droolsjbpm-build-bootstrap.git // clones droolsjbpm-knowledge, then drools, then drools-planner, ... $ droolsjbpm-build-bootstrap/script/git-clone-others.sh // builds droolsjbpm-knowledge, then drools, then drools-planner, ... $ droolsjbpm-build-bootstrap/script/mvn-all.sh clean install -DskipTests // Note: drools-planner depends on a SNAPSHOT of drools // Wait one day $ cd drools-planner $ mvn clean install -nsu -DskipTests // It downloads drools-20110727-... pom and jar
Hide
Permalink
Geoffrey De Smet added a comment - - edited

Note, we do have this is in our parent pom:

  <repositories>
    <repository>
      <id>jboss-public-repository-group</id>
      ...
      <snapshots>
        <enabled>true</enabled>
        <updatePolicy>daily</updatePolicy>
      </snapshots>
    </repository>

But the -nsu should take precedence over that updatePolicy=daily, because command line always overwrites configuration.
The workflow is:

  • Either you've just git pulled, so you mvn build to fetch the latest snapshot (as previous snapshots might be binary incompatible with the latest code)
  • Or, you've haven't git pulled in a while, so you mvn -nsu build to verify your local changes and you don't want the latest snapshot (which might be binary incompatible because you don't have the latest code)
Show
Geoffrey De Smet added a comment - - edited Note, we do have this is in our parent pom: <repositories> <repository> <id>jboss- public -repository-group</id> ... <snapshots> <enabled> true </enabled> <updatePolicy>daily</updatePolicy> </snapshots> </repository> But the -nsu should take precedence over that updatePolicy=daily, because command line always overwrites configuration. The workflow is: Either you've just git pulled, so you mvn build to fetch the latest snapshot (as previous snapshots might be binary incompatible with the latest code) Or, you've haven't git pulled in a while, so you mvn -nsu build to verify your local changes and you don't want the latest snapshot (which might be binary incompatible because you don't have the latest code)
Hide
Permalink
Benjamin Bentmann added a comment -

Fixed in r1151418.

Show
Benjamin Bentmann added a comment - Fixed in r1151418 .

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Geoffrey De Smet
Vote (3)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: