Maven 2 & 3

CLONE - JAVA_HOME auto discovery - also for windows with mvn.bat

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 3.0.2
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    Linux, Ubuntu
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

When JAVA_HOME is not set (but java command is in the PATH) then bin/mvn script prints warning message "Warning: JAVA_HOME environment variable is not set."
I don't want to explicitly set JAVA_HOME variable because I manage my JDK instances by update-java-alternatives in Ubuntu. It switches system wide JDK, but does not set the JAVA_HOME variable. If I would set JAVA_HOME manually then any changes made by update-java-alternatives would not be reflected in JAVA_HOME which is obviously incorrect.

However mvn script can be improved, so that it can guess JAVA_HOME. Actually Groovy startup script does it very well, so I moved auto-discovery code from groovy script to mvn and attach patch here

  1. File
    mvn.bat
    24/Feb/11 4:35 PM
    6 kB
    Jochen Stiepel

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. MNG-5020 JAVA_HOME auto discovery

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jochen Stiepel added a comment -

for windows there is also a part in the startGroovy.bat
http://svn.codehaus.org/groovy/trunk/groovy/groovy-core/src/bin/startGroovy.bat

this could be added to the mvn.bat:

@REM ==== START VALIDATION ====
if not "%JAVA_HOME%" == "" goto OkJHome
for %%P in (%PATH%) do if exist %%P\..\bin\java.exe set JAVA_HOME=%%P\..
if not "%JAVA_HOME%" == "" goto OkJHome

echo ERROR: JAVA_HOME not found in your environment.
echo Attempting to find JAVA_HOME from PATH also failed.
echo Please set the JAVA_HOME variable in your environment to match the
echo location of your Java installation
echo.
goto error
Show
Jochen Stiepel added a comment - for windows there is also a part in the startGroovy.bat http://svn.codehaus.org/groovy/trunk/groovy/groovy-core/src/bin/startGroovy.bat this could be added to the mvn.bat: @REM ==== START VALIDATION ==== if not "%JAVA_HOME%" == "" goto OkJHome for %%P in (%PATH%) do if exist %%P\..\bin\java.exe set JAVA_HOME=%%P\.. if not "%JAVA_HOME%" == "" goto OkJHome echo ERROR: JAVA_HOME not found in your environment. echo Attempting to find JAVA_HOME from PATH also failed. echo Please set the JAVA_HOME variable in your environment to match the echo location of your Java installation echo. goto error
Hide
Permalink
Jochen Stiepel added a comment -

the changed mvn.bat

Show
Jochen Stiepel added a comment - the changed mvn.bat

People

  • Assignee:
    Unassigned
    Reporter:
    Jochen Stiepel
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: