Maven 2 & 3

Profile activated accidentially

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 2.2.1
  • Fix Version/s: None
  • Component/s: Profiles
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

When you define a profile activated like

  ...
  <profiles>
    <profile>
      <id>someCase</id>
      <activation>
        <activeByDefault>false</activeByDefault>
        <property>
          <name>somePropertyName</name>
          <value>!Value</value>
        </property>
      </activation>
      ...
    </profile>
  </profiles>
  ...

this profile will also be activated when no property/profile is defined on the command line. I expected that profile beeing activated only when you supply -DsomePropertyName=NotTheValue.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Bentmann added a comment - - edited

This works as designed, since "Value".equals( System.getProperty( "somePropertyName" ) ) == false when somePropertyName has not been specified.

Show
Benjamin Bentmann added a comment - - edited This works as designed, since "Value".equals( System.getProperty( "somePropertyName" ) ) == false when somePropertyName has not been specified.
Hide
Permalink
Maik Richey added a comment -

But then there is no difference to

      ...
      <activation>
        <activeByDefault>false</activeByDefault>
        <property>
          <name>!somePropertyName</name>
        </property>
      </activation>
      ...

and make no sense for me.

By specifying <name>somePropertyName</name> I would expect that property being there but not having the value "Value". That makes the difference.

To be more precise:
What I would like to do is defining some properties as default. The same properties should be used when activating a profile by property "env" and the value "target". Different properties should be used - and are defined in another profile - when specifying the property "env" with a value other than "target" to activate that profile. So the only way, rather than creating a profile for each possible value, is the way I tried to manage it and that's the way how it should work in my opinion.

Show
Maik Richey added a comment - But then there is no difference to ... <activation> <activeByDefault> false </activeByDefault> <property> <name>!somePropertyName</name> </property> </activation> ... and make no sense for me. By specifying <name>somePropertyName</name> I would expect that property being there but not having the value "Value". That makes the difference. To be more precise: What I would like to do is defining some properties as default. The same properties should be used when activating a profile by property "env" and the value "target". Different properties should be used - and are defined in another profile - when specifying the property "env" with a value other than "target" to activate that profile. So the only way, rather than creating a profile for each possible value, is the way I tried to manage it and that's the way how it should work in my opinion.
Hide
Permalink
Maik Richey added a comment -

see my last comment

Show
Maik Richey added a comment - see my last comment
Hide
Permalink
Maik Richey added a comment -

Created and attached a patch for SystemPropertyProfileActivator covering the difference mentioned. Please check it and give some feedback.

Show
Maik Richey added a comment - Created and attached a patch for SystemPropertyProfileActivator covering the difference mentioned. Please check it and give some feedback.

People

  • Assignee:
    Unassigned
    Reporter:
    Maik Richey
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: