Maven 2 & 3

NPE in dependency resolution code for TC plugin

Details

  • Complexity:
    Intermediate
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

Terracotta Maven plugin 1.4.0 test produces NPE in 3.0-beta-3, but works fine in 3.0-beta-2

[ERROR] [node0]
java.lang.NullPointerException
	at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:149)
	at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:139)
	at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:237)
	at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:219)
	at org.apache.maven.project.artifact.MavenMetadataSource.retrieveRelocatedProject(MavenMetadataSource.java:584)
	at org.apache.maven.project.artifact.MavenMetadataSource.retrieve(MavenMetadataSource.java:192)
	at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:532)
	at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.collect(DefaultLegacyArtifactCollector.java:144)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:451)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveWithExceptions(DefaultArtifactResolver.java:307)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:301)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:280)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:258)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:243)
	at org.terracotta.maven.plugins.tc.DsoArtifactResolverImpl.resolveArtifact(DsoArtifactResolverImpl.java:145)
	at org.terracotta.maven.plugins.tc.DsoSurefireMojo.addArtifact(DsoSurefireMojo.java:775)
	at org.terracotta.maven.plugins.tc.DsoSurefireMojo.constructSurefireBooter(DsoSurefireMojo.java:548)
	at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.runSurefire(DsoSurefireMojo.java:434)
	at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.run(DsoSurefireMojo.java:417)
	at java.lang.Thread.run(Thread.java:637)
[INFO] All nodes completed
[INFO] ------------------------------------------------------------------------
[INFO] Stopping DSO Server
[INFO] [dso stop] 2010-08-30 11:10:42,625 INFO - Terracotta 3.1.0, as of 20090821-080813 (Revision 13442 by cruise@su10mo5 from 3.1)
[INFO] OK
[

Test project - attached

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-4866 DefaultLegacySupport leaks MavenSession instances in some cases

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Stuart McCulloch added a comment -

Could you double-check you're using the re-spun maven-3.0-beta-3, because the stack trace attached to MNG-4785 doesn't match the code in aether-1.2.
It does however match code in the previous aether release from the earlier maven-3.0-beta-3 attempt (which had a known NPE issue, hence the respin).

https://repository.apache.org/content/repositories/maven-157/org/apache/maven/apache-maven/3.0-beta-3/

Show
Stuart McCulloch added a comment - Could you double-check you're using the re-spun maven-3.0-beta-3, because the stack trace attached to MNG-4785 doesn't match the code in aether-1.2. It does however match code in the previous aether release from the earlier maven-3.0-beta-3 attempt (which had a known NPE issue, hence the respin). https://repository.apache.org/content/repositories/maven-157/org/apache/maven/apache-maven/3.0-beta-3/
Hide
Permalink
Oleg Gusakov added a comment - - edited

My bad - attached the wrong stack (multi-tab terminals are evil

Maven version:

mvn -v
Apache Maven 3.0-beta-3 (r990787; 2010-08-30 05:44:03-0700)
Java version: 1.6.0_20
Java home: /System/Library/Frameworks/JavaVM.framework/Versions/1.6.0/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x" version: "10.6.4" arch: "x86_64" Family: "mac"

You can recreate the NPE using attached project - do mvn clean test in it. 3.0-beta-2 did not have it.
Stack trace:

[ERROR] [node0]
java.lang.NullPointerException
	at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:185)
	at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:175)
	at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:237)
	at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:219)
	at org.apache.maven.project.artifact.MavenMetadataSource.retrieveRelocatedProject(MavenMetadataSource.java:584)
	at org.apache.maven.project.artifact.MavenMetadataSource.retrieve(MavenMetadataSource.java:192)
	at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:532)
	at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.collect(DefaultLegacyArtifactCollector.java:144)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:451)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveWithExceptions(DefaultArtifactResolver.java:307)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:301)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:280)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:258)
	at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:243)
	at org.terracotta.maven.plugins.tc.DsoArtifactResolverImpl.resolveArtifact(DsoArtifactResolverImpl.java:145)
	at org.terracotta.maven.plugins.tc.DsoSurefireMojo.addArtifact(DsoSurefireMojo.java:775)
	at org.terracotta.maven.plugins.tc.DsoSurefireMojo.constructSurefireBooter(DsoSurefireMojo.java:548)
	at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.runSurefire(DsoSurefireMojo.java:434)
	at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.run(DsoSurefireMojo.java:417)
	at java.lang.Thread.run(Thread.java:637)
[INFO] All nodes completed
[INFO] ------------------------------------------------------------------------
[INFO] Stopping DSO Server
[INFO] [dso stop] 2010-08-30 19:37:17,807 INFO - Terracotta 3.1.0, as of 20090821-080813 (Revision 13442 by cruise@su10mo5 from 3.1)
[INFO] OK
Show
Oleg Gusakov added a comment - - edited My bad - attached the wrong stack (multi-tab terminals are evil Maven version: mvn -v Apache Maven 3.0-beta-3 (r990787; 2010-08-30 05:44:03-0700) Java version: 1.6.0_20 Java home: / System /Library/Frameworks/JavaVM.framework/Versions/1.6.0/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x" version: "10.6.4" arch: "x86_64" Family: "mac" You can recreate the NPE using attached project - do mvn clean test in it. 3.0-beta-2 did not have it. Stack trace: [ERROR] [node0] java.lang.NullPointerException at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:185) at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:175) at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:237) at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:219) at org.apache.maven.project.artifact.MavenMetadataSource.retrieveRelocatedProject(MavenMetadataSource.java:584) at org.apache.maven.project.artifact.MavenMetadataSource.retrieve(MavenMetadataSource.java:192) at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:532) at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.collect(DefaultLegacyArtifactCollector.java:144) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:451) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveWithExceptions(DefaultArtifactResolver.java:307) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:301) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:280) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:258) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:243) at org.terracotta.maven.plugins.tc.DsoArtifactResolverImpl.resolveArtifact(DsoArtifactResolverImpl.java:145) at org.terracotta.maven.plugins.tc.DsoSurefireMojo.addArtifact(DsoSurefireMojo.java:775) at org.terracotta.maven.plugins.tc.DsoSurefireMojo.constructSurefireBooter(DsoSurefireMojo.java:548) at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.runSurefire(DsoSurefireMojo.java:434) at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.run(DsoSurefireMojo.java:417) at java.lang. Thread .run( Thread .java:637) [INFO] All nodes completed [INFO] ------------------------------------------------------------------------ [INFO] Stopping DSO Server [INFO] [dso stop] 2010-08-30 19:37:17,807 INFO - Terracotta 3.1.0, as of 20090821-080813 (Revision 13442 by cruise@su10mo5 from 3.1) [INFO] OK
Hide
Permalink
Stuart McCulloch added a comment -

I've just recreated this particular NPE with the re-spun beta-3 so it looks like there is still a bug:

[ERROR] [node0]
java.lang.NullPointerException
  at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:185)
  at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:175)
  at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:237)
  at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:219)
  at org.apache.maven.project.artifact.MavenMetadataSource.retrieveRelocatedProject(MavenMetadataSource.java:584)
  at org.apache.maven.project.artifact.MavenMetadataSource.retrieve(MavenMetadataSource.java:192)
  at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:532)
  at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.collect(DefaultLegacyArtifactCollector.java:144)
  at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:451)
  at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveWithExceptions(DefaultArtifactResolver.java:307)
  at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:301)
  at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:280)
  at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:258)
  at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:243)
  at org.terracotta.maven.plugins.tc.DsoArtifactResolverImpl.resolveArtifact(DsoArtifactResolverImpl.java:145)
  at org.terracotta.maven.plugins.tc.DsoSurefireMojo.addArtifact(DsoSurefireMojo.java:775)
  at org.terracotta.maven.plugins.tc.DsoSurefireMojo.constructSurefireBooter(DsoSurefireMojo.java:548)
  at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.runSurefire(DsoSurefireMojo.java:434)
  at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.run(DsoSurefireMojo.java:417)
  at java.lang.Thread.run(Thread.java:619)
Show
Stuart McCulloch added a comment - I've just recreated this particular NPE with the re-spun beta-3 so it looks like there is still a bug: [ERROR] [node0] java.lang.NullPointerException at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:185) at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:175) at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:237) at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:219) at org.apache.maven.project.artifact.MavenMetadataSource.retrieveRelocatedProject(MavenMetadataSource.java:584) at org.apache.maven.project.artifact.MavenMetadataSource.retrieve(MavenMetadataSource.java:192) at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.recurse(DefaultLegacyArtifactCollector.java:532) at org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector.collect(DefaultLegacyArtifactCollector.java:144) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:451) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveWithExceptions(DefaultArtifactResolver.java:307) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:301) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:280) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:258) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolveTransitively(DefaultArtifactResolver.java:243) at org.terracotta.maven.plugins.tc.DsoArtifactResolverImpl.resolveArtifact(DsoArtifactResolverImpl.java:145) at org.terracotta.maven.plugins.tc.DsoSurefireMojo.addArtifact(DsoSurefireMojo.java:775) at org.terracotta.maven.plugins.tc.DsoSurefireMojo.constructSurefireBooter(DsoSurefireMojo.java:548) at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.runSurefire(DsoSurefireMojo.java:434) at org.terracotta.maven.plugins.tc.DsoSurefireMojo$SurefireThread.run(DsoSurefireMojo.java:417) at java.lang. Thread .run( Thread .java:619)
Hide
Permalink
Stuart McCulloch added a comment -

Looks like the DsoSurefireMojo spawns a child thread that uses the legacy Maven resolution API. The new beta uses a threadlocal (see org.apache.maven.plugin.internal.DefaultLegacySupport) to provide access to the Maven session from legacy components, but of course this threadlocal is only valid for the executing mojo thread - not the spawned child thread.

Changing DefaultLegacySupport to use an InheritableThreadLocal should solve this NPE, but I'm not sure what impact this would have wrt. cleanup of the Maven session given that Maven has no knowledge of the child thread...

Show
Stuart McCulloch added a comment - Looks like the DsoSurefireMojo spawns a child thread that uses the legacy Maven resolution API. The new beta uses a threadlocal (see org.apache.maven.plugin.internal.DefaultLegacySupport) to provide access to the Maven session from legacy components, but of course this threadlocal is only valid for the executing mojo thread - not the spawned child thread. Changing DefaultLegacySupport to use an InheritableThreadLocal should solve this NPE, but I'm not sure what impact this would have wrt. cleanup of the Maven session given that Maven has no knowledge of the child thread...
Hide
Permalink
Benjamin Bentmann added a comment -

Fixed in r995457.

Show
Benjamin Bentmann added a comment - Fixed in r995457 .

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Oleg Gusakov
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: