Maven 2 & 3

SCM uses artifactId in multi module builds, regardeless of the module name

Details

  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

hallo

in a multi-module build, when the changelog plugin is configured within the parent pom the location in scm is created using the artifactId. In our projects the actual modules are not named like this.

we have:
parentpom.xml

  • module.a.core.stuff (artifactId module-a-core-stuff)
  • module.b.core.things (artifactId module-b-core-stuff)
  • ...

the parent pom contains the modules section referring to the modules with module.a.core.stuff (the actual folder name)

the changelog plugin will use the artifactId to look up changes in scm, which will create a wrong path (http://localhost/trunk/module-a-core-stuff instead of http://localhost/trunk/module.a.core.stuff)

i would like some configuration option in the parent pom to define what name shall be used ($

{project.artifactId}

or $

{project.name}

for example). so the module name can be matched if it is not the same as the artifactId.

thanks

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-3244 inherited site url not properly handling parameters

  • Major - Major loss of function.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dennis Lundberg added a comment -

I think that this issue really belongs in maven-scm, but first let us see if it hasn't been fixed already.

Please upgrade to version 2.1 of maven-changelog-plugin and try again. It has lots of fixes and, most importantly, uses maven-scm-1.0.

Show
Dennis Lundberg added a comment - I think that this issue really belongs in maven-scm, but first let us see if it hasn't been fixed already. Please upgrade to version 2.1 of maven-changelog-plugin and try again. It has lots of fixes and, most importantly, uses maven-scm-1.0.
Hide
Permalink
Damien Lecan added a comment -

Same problem for me, with changelog-plugin 2.1

The plugin tries to use artifactId instead of module name

Show
Damien Lecan added a comment - Same problem for me, with changelog-plugin 2.1 The plugin tries to use artifactId instead of module name
Hide
Permalink
Felix Knecht added a comment -

I think the problem is in https://svn.apache.org/repos/asf/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java

It uses artifactId to generate the repository path instead of the module name.

private void assembleScmInheritance( Model child, Model parent, String childPathAdjustment, boolean appendPaths )
{
if ( parent.getScm() != null )
{
Scm parentScm = parent.getScm();

Scm childScm = child.getScm();

if ( childScm == null )

{ childScm = new Scm(); child.setScm( childScm ); }

if ( StringUtils.isEmpty( childScm.getConnection() ) && !StringUtils.isEmpty( parentScm.getConnection() ) )

{ childScm.setConnection( appendPath( parentScm.getConnection(), child.getArtifactId(), childPathAdjustment, appendPaths ) ); }

if ( StringUtils.isEmpty( childScm.getDeveloperConnection() ) &&
!StringUtils.isEmpty( parentScm.getDeveloperConnection() ) )

{ childScm .setDeveloperConnection( appendPath( parentScm.getDeveloperConnection(), child.getArtifactId(), childPathAdjustment, appendPaths ) ); }

if ( StringUtils.isEmpty( childScm.getUrl() ) && !StringUtils.isEmpty( parentScm.getUrl() ) )

{ childScm.setUrl( appendPath( parentScm.getUrl(), child.getArtifactId(), childPathAdjustment, appendPaths ) ); }

}
}

Show
Felix Knecht added a comment - I think the problem is in https://svn.apache.org/repos/asf/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java It uses artifactId to generate the repository path instead of the module name. private void assembleScmInheritance( Model child, Model parent, String childPathAdjustment, boolean appendPaths ) { if ( parent.getScm() != null ) { Scm parentScm = parent.getScm(); Scm childScm = child.getScm(); if ( childScm == null ) { childScm = new Scm(); child.setScm( childScm ); } if ( StringUtils.isEmpty( childScm.getConnection() ) && !StringUtils.isEmpty( parentScm.getConnection() ) ) { childScm.setConnection( appendPath( parentScm.getConnection(), child.getArtifactId(), childPathAdjustment, appendPaths ) ); } if ( StringUtils.isEmpty( childScm.getDeveloperConnection() ) && !StringUtils.isEmpty( parentScm.getDeveloperConnection() ) ) { childScm .setDeveloperConnection( appendPath( parentScm.getDeveloperConnection(), child.getArtifactId(), childPathAdjustment, appendPaths ) ); } if ( StringUtils.isEmpty( childScm.getUrl() ) && !StringUtils.isEmpty( parentScm.getUrl() ) ) { childScm.setUrl( appendPath( parentScm.getUrl(), child.getArtifactId(), childPathAdjustment, appendPaths ) ); } } }
Hide
Permalink
Michael Semb Wever added a comment - - edited

If it's in DefaultModelInheritanceAssembler.java then this issue should be moved to "Maven Project Builder" ?

--> http://jira.codehaus.org/browse/MNG

Show
Michael Semb Wever added a comment - - edited If it's in DefaultModelInheritanceAssembler.java then this issue should be moved to "Maven Project Builder" ? --> http://jira.codehaus.org/browse/MNG
Hide
Permalink
Michael Semb Wever added a comment -

Looks like it's MNG-2006

Show
Michael Semb Wever added a comment - Looks like it's MNG-2006

People

  • Assignee:
    Unassigned
    Reporter:
    werner mueller
Vote (10)
Watch (9)

Dates

  • Created:
    Updated: