Maven 2 & 3

Multiple profile activation conditions does not work

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.2.1
  • Fix Version/s: Issues to be reviewed for 3.x
  • Component/s: Profiles
  • Labels:
    None
  • Environment:
    All platforms.
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

According to the documentation at http://www.sonatype.com/books/mvnref-book/reference/profiles-sect-activation.html a profile is activated when all activation conditions are met (which makes sense of course). But when I try to use this it does not work. It seems maven does an OR instead of an AND (which is not rearly as useful and is the opposite of what the documentation says at the previous link).

For example, if I have one profile that is activated like this:

<activation>
<activeByDefault>false</activeByDefault>
<os>
<name>linux</name>
</os>
</activation>

and another profile that is activated like this:

<activation>
<activeByDefault>false</activeByDefault>
<os>
<name>linux</name>
</os>
<property>
<name>release</name>
<value>true</value>
</property>
</activation>

Then I would expect the second profile to only be activated if the OS is linux and the release property is defined.

When I run 'mvn help:active-profiles' however, maven shows that both profiles are active even though the release property is not defined.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-4516 Contradiction between the documentation and Maven's behavior related to profile-activation with multiple criteria

  • Critical - Crashes, loss of data, severe memory leak.
  • Open - The issue is open and ready for the assignee to start work on it.

Bug - A problem which impairs or prevents the functions of the product. MNG-3106 Multiple profile activation conditions broken

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

New Feature - A new feature of the product, which has yet to be developed. MNG-1753 support improved property based profile activation

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. MNG-3328 Allow multiple profile activation properties.

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Improvement - An improvement or enhancement to an existing feature or task. MNG-5194 Profile activation: Allow expressions in <activation>

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
relates to

Improvement - An improvement or enhancement to an existing feature or task. MNG-3328 Allow multiple profile activation properties.

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Clemens Fuchslocher added a comment -

POM Reference:

Activation occurs when one or more of the specified criteria have been met. When the first positive result is encountered, processing stops and the profile is marked as active.

Not really useful.

Show
Clemens Fuchslocher added a comment - POM Reference : Activation occurs when one or more of the specified criteria have been met. When the first positive result is encountered, processing stops and the profile is marked as active. Not really useful.
Hide
Permalink
Clemens Fuchslocher added a comment -

This was introduced by MNG-3106:

The new behaviour is that the profile will be activated if any of the activators returns true (i.e. an "or" operation).

Show
Clemens Fuchslocher added a comment - This was introduced by MNG-3106 : The new behaviour is that the profile will be activated if any of the activators returns true (i.e. an "or" operation).
Hide
Permalink
Clemens Fuchslocher added a comment -

An and element would be useful:

<activation>
	<activeByDefault>false</activeByDefault>
	<and/>
	<os>
		<name>linux</name>
	</os>
	<property>
		<name>release</name>
		<value>true</value>
	</property>
</activation>
Show
Clemens Fuchslocher added a comment - An and element would be useful: <activation> <activeByDefault>false</activeByDefault> <and/> <os> <name>linux</name> </os> <property> <name>release</name> <value>true</value> </property> </activation>
Hide
Permalink
Peter Goodwine added a comment -

Settings Reference:

Activation occurs when all specified criteria have been met, though not all are required at once.

Contradicts the POM reference, worse than "not really useful"

Show
Peter Goodwine added a comment - Settings Reference : Activation occurs when all specified criteria have been met, though not all are required at once. Contradicts the POM reference, worse than "not really useful"
Hide
Permalink
Eric Pabst added a comment - - edited

I have a fix for this here that doesn't modify the pom schema at all and simply switches it from an OR to and AND:
https://github.com/epabst/maven-3/tree/MNG-4516

Show
Eric Pabst added a comment - - edited I have a fix for this here that doesn't modify the pom schema at all and simply switches it from an OR to and AND: https://github.com/epabst/maven-3/tree/MNG-4516
Hide
Permalink
Hung Huynh added a comment -

supporting for both "AND" and "OR" logic would be greatly useful

Show
Hung Huynh added a comment - supporting for both "AND" and "OR" logic would be greatly useful
Hide
Permalink
Ivan added a comment -

What is the status of that fix ?

Show
Ivan added a comment - What is the status of that fix ?
Hide
Permalink
Karel Piwko added a comment -

Guys, you can check following Maven extension https://github.com/kpiwko/el-profile-activator-extension.

You just drop two jars into $MAVEN_HOME/lib/ext and you'll get MVEL support in <property> value.

Show
Karel Piwko added a comment - Guys, you can check following Maven extension https://github.com/kpiwko/el-profile-activator-extension . You just drop two jars into $MAVEN_HOME/lib/ext and you'll get MVEL support in <property> value.
Hide
Permalink
Ondrej Zizka added a comment -

Seems that Karel's extension solves MNG-5194.

Show
Ondrej Zizka added a comment - Seems that Karel's extension solves MNG-5194 .
Hide
Permalink
Ronny Pscheidl added a comment -

This extension should solve the problem when all activation conditions are met:

https://github.com/johnjcool/and-activation-profile-selector

Show
Ronny Pscheidl added a comment - This extension should solve the problem when all activation conditions are met: https://github.com/johnjcool/and-activation-profile-selector

People

  • Assignee:
    Brian Fox
    Reporter:
    Nicholas Allen
Vote (42)
Watch (35)

Dates

  • Created:
    Updated: