Maven 2 & 3

Integration test MNG1830 fails with GIT based forks

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.0-alpha-5
  • Fix Version/s: 3.0-alpha-6
  • Component/s: Integration Tests
  • Labels:
    None
  • Environment:
    linux
  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

Git is rapidly becoming the tool of choice for working with forks/patches of svn projects. MavenITmng1830ShowVersionTest fails if no svn repo is present.

The enclosed patches need to be applied in maven3 trunk (mng1830GitVersionNumber.patch), and adds a profile that activates a different buildnumber plugin setting
when no ".svn" folder is present.

I have made no attempts at being overly clever with the version number, which is basically "rGIT; <date>".

The second patch is for MavenITmng1830ShowVersionTest to accept this format in addition to the two others.

Since this fix is mostly in the test, there is no additional testcase.

  1. Text File
    mng1830GitCheck.patch
    13/Dec/09 3:09 PM
    1.0 kB
    Kristian Rosenvold
  2. Text File
    mng1830GitVersionNumber.patch
    13/Dec/09 3:09 PM
    1 kB
    Kristian Rosenvold

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kristian Rosenvold added a comment -

This patch is not good, will be back shortly with reworked version

Show
Kristian Rosenvold added a comment - This patch is not good, will be back shortly with reworked version
Hide
Permalink
Benjamin Bentmann added a comment -

Fixed in r890355.

Show
Benjamin Bentmann added a comment - Fixed in r890355 .

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Kristian Rosenvold
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: