Maven 2 & 3

Interpolation of environment variables is not case-insensitive on Windows

Details

  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

00:47  wsmoak  I can't get ${env.PATH} to be evaluated in the pom... but only on Windows. Any ideas?
00:47  wsmoak  echo %PATH% produces the right stuff. and it works fine with Maven 2.0.9 on OS X or linux

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. PLXUTILS-82 Make CommandLineUtils.getSystemEnvVars() use casing rule of platform

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

New Feature - A new feature of the product, which has yet to be developed. MNG-1525 Allow environment variables to be referenced in pom.xml, settings.xml, etc.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-4136 Regression: Environment Variables With Parenthesis Can't Be Referenced in POM

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Wendy Smoak added a comment -

Thanks, Benjamin.

I was testing this by adding <properties><mypath>$

{env.PATH}</mypath></properties> to a pom and then running mvn help:effective-pom.

On Linux and OS X, the effective pom shows all the directories in the PATH environment variable. On Windows, it remains literally ${env.PATH}

.

However, $

{env.M2_HOME}

is expanded on all three OSs, so it's not all environment variables on Windows.

Show
Wendy Smoak added a comment - Thanks, Benjamin. I was testing this by adding <properties><mypath>$ {env.PATH}</mypath></properties> to a pom and then running mvn help:effective-pom. On Linux and OS X, the effective pom shows all the directories in the PATH environment variable. On Windows, it remains literally ${env.PATH} . However, $ {env.M2_HOME} is expanded on all three OSs, so it's not all environment variables on Windows.
Hide
Permalink
Benjamin Bentmann added a comment -

Yep, it's only those env vars whose names are not natively all upper-case. For instance, the real name of the PATH var on WinXP is "Path".

Show
Benjamin Bentmann added a comment - Yep, it's only those env vars whose names are not natively all upper-case. For instance, the real name of the PATH var on WinXP is "Path".
Hide
Permalink
Benjamin Bentmann added a comment -

Fixed in r729060, r729061 and r729066, respectively.

The "fix" is not perfect in the sense that the env var lookup during interpolation is still not case-insensitive on Windows, e.g. {{$

{env.Path}

}} is not recognized. Instead, the native env var names are normalized to upper-case, which should be good enough for the major use cases.

Show
Benjamin Bentmann added a comment - Fixed in r729060 , r729061 and r729066 , respectively. The "fix" is not perfect in the sense that the env var lookup during interpolation is still not case-insensitive on Windows, e.g. {{$ {env.Path} }} is not recognized. Instead, the native env var names are normalized to upper-case, which should be good enough for the major use cases.
Hide
Permalink
Paul Benedict added a comment -

You could use a TreeMap with a String#CASE_INSENSITIVE_ORDER Comparator too.

Show
Paul Benedict added a comment - You could use a TreeMap with a String#CASE_INSENSITIVE_ORDER Comparator too.
Hide
Permalink
Benjamin Bentmann added a comment -

The problem is not finding a data structure to do case-insensitive lookups, the problem is to integrate that into the existing code. For instance, the env vars are end up in the same Properties instance as used for system/execution properties...

Show
Benjamin Bentmann added a comment - The problem is not finding a data structure to do case-insensitive lookups, the problem is to integrate that into the existing code. For instance, the env vars are end up in the same Properties instance as used for system/execution properties...

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Benjamin Bentmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: