Maven 2 & 3

[regression] Some POMs fail to parse if the are subject to ModelContainer joining

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 3.0-alpha-1
  • Fix Version/s: 3.0-alpha-1
  • Component/s: POM
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

With Maven 3.0-SNAPSHOT built from svn r713815, the POM in the attachment fails to parse with the output in fail.log. The interesting bit is reproduced here:

java.io.IOException: org.codehaus.plexus.util.xml.pull.XmlPullParserException: end tag name </plugin> must match start tag name <dependencies> from line 12 (position: START_TAG seen ...<dependencies></plugin>... @12:24) :

<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"  xmlns="http://maven.apache.org/POM/4.0.0" >
<modelVersion>4.0.0</modelVersion>
<groupId>testing</groupId>
<artifactId>testing</artifactId>
<version>1</version>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<dependencies></plugin>
<plugin>
[...lots more...]

As far as I can make out, the problem is that the ModelContainer joining carried out in ModelTransformerContext.transform (on line 269) fails to take into account that it may leave the wrapper collection empty. Such an empty collection then leads ModelMarshaller astray later.

The example POM is a stripped-down version of the org.apache.cxf:cfx-parent:2.1 POM, which is how I discovered the issue.

This broke sometime after 2008-10-13.

Issue Links

Activity

Hide
Benjamin Bentmann added a comment -

The example POM has been added to the IT suite, thanks very much Espen!

Show
Benjamin Bentmann added a comment - The example POM has been added to the IT suite, thanks very much Espen!
Hide
Benjamin Bentmann added a comment -

Fixed in r727855.

Show
Benjamin Bentmann added a comment - Fixed in r727855.

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: