[regression] Class folder system dependency doesn't work anymore

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 2.1.0-M1
  • Fix Version/s: None
  • Component/s: Artifacts and Repositories
  • Labels:
    None
  • Environment:
    Any
  • Complexity:
    Intermediate

Description

My project use system dependencies pointing to class folders.

<dependency>
<groupId>class-folder</groupId>
<artifactId>class-folder</artifactId>
<version>N</version>
<scope>system</scope>
<systemPath>C:/appli/classes</systemPath>
</dependency>

Such class folders dependencies worked fine with maven 2.0.7
They are needed by my project as it relies on a legacy application not packaged into a jar file.

Root cause is located in file DefaultArtifactResolver.java:

if ( !systemFile.isFile() )

{ throw new ArtifactNotFoundException( "System artifact: " + artifact + " is not a file: " + systemFile, artifact ); }

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-3288 Invalid systemPath allows build to continue--failing in later phase.

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Francois Loison added a comment -

Patch proposal correcting issue.

Show
Francois Loison added a comment - Patch proposal correcting issue.
Hide
Permalink
Benjamin Bentmann added a comment -

Use case conflicts with MNG-3288

Show
Benjamin Bentmann added a comment - Use case conflicts with MNG-3288
Hide
Permalink
Benjamin Bentmann added a comment -

Integrations tests, one for each possible outcome of this.

Show
Benjamin Bentmann added a comment - Integrations tests, one for each possible outcome of this.
Hide
Permalink
Francois Loison added a comment -

Ok, I'll test the 2 integration tests you wrote and a a specific test for this use case.

Regards,
François

Show
Francois Loison added a comment - Ok, I'll test the 2 integration tests you wrote and a a specific test for this use case. Regards, François
Hide
Permalink
Francois Loison added a comment -

I tested fix OK using integration tests Benjamin provided.

I applied fix on:
components/branches/maven-2.1.x/maven-artifact-manager/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactResolver.java

I added Benjamin integration tests on:
core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java

New test case pass with fix.
I tested also that new test case fails without fix.

Other test results are unchanged with or without fix.

Regards,
François

Show
Francois Loison added a comment - I tested fix OK using integration tests Benjamin provided. I applied fix on: components/branches/maven-2.1.x/maven-artifact-manager/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactResolver.java I added Benjamin integration tests on: core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java New test case pass with fix. I tested also that new test case fails without fix. Other test results are unchanged with or without fix. Regards, François
Hide
Permalink
Francois Loison added a comment -

Patch for bug MNG-3768 applicable to http://svn.apache.org/repos/asf/maven/components/branches/maven-2.1.x

Show
Francois Loison added a comment - Patch for bug MNG-3768 applicable to http://svn.apache.org/repos/asf/maven/components/branches/maven-2.1.x
Hide
Permalink
Brett Porter added a comment -

Francois... when I apply that patch, 3288 still fails. The cases are certainly incompatible.

Is there really no way you can package those classes into an artifact?

Show
Brett Porter added a comment - Francois... when I apply that patch, 3288 still fails. The cases are certainly incompatible. Is there really no way you can package those classes into an artifact?
Hide
Permalink
Brett Porter added a comment -

since there's no response and no votes, and the length of time this release has been out there - I think we should stick with the behaviour of MNG-3288

Show
Brett Porter added a comment - since there's no response and no votes, and the length of time this release has been out there - I think we should stick with the behaviour of MNG-3288

People

  • Assignee:
    Unassigned
    Reporter:
    Francois Loison
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: