Small change to artifact version parsing.

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.0.9
  • Fix Version/s: 3.1
  • Component/s: General
  • Labels:
    None
  • Complexity:
    Intermediate

Description

We currently many projects that use an OSGi compatible scheme for release version numbers. The OSGi spec does not currently allow a "-" to determine the location of the qualifier. So instead of the maven standard like this:

1.0.1-beta-1

We have something like this:

1.0.1.beta1

Maven's currently handles this by treating the entire version string as a classifier. It would be helpful this could be parsed as
major = 1
minor = 0
incremental = 1
qualifier = beta1

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-3010 Problem parsing version ranges

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. MNG-3518 Handle date qualifier in DefaultArtifactVersion

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. MNGECLIPSE-281 Version numbers are compared as strings

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul Gier added a comment -

Attaching a patch with the change to the DefaultArtifactVersion, and updates to the unit tests.

Show
Paul Gier added a comment - Attaching a patch with the change to the DefaultArtifactVersion, and updates to the unit tests.
Hide
Permalink
Vincent Siveton added a comment -

Other related issue.

Show
Vincent Siveton added a comment - Other related issue.
Hide
Permalink
Herve Boutemy added a comment -

the idea seems interesting, but this change breaks toString() result:

new DefaultArtifactVersion( "1.0.1.beta1" ).toString() -> "1.0.1-beta1"
Show
Herve Boutemy added a comment - the idea seems interesting, but this change breaks toString() result: 
new DefaultArtifactVersion( "1.0.1.beta1" ).toString() -> "1.0.1-beta1"
Hide
Permalink
Benjamin Bentmann added a comment -

Should be possible to fix toString() by just using comparable.toString() instead of trying to reconstruct the string from the parsed bits.

Show
Benjamin Bentmann added a comment - Should be possible to fix toString() by just using comparable.toString() instead of trying to reconstruct the string from the parsed bits.

People

  • Assignee:
    Unassigned
    Reporter:
    Paul Gier
Vote (2)
Watch (6)

Dates

  • Created:
    Updated: