Maven
  1. Maven
  2. MNG-3509

Make "mvn -v" output locale/encoding

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.8
    • Fix Version/s: 2.0.11, 2.1.0-M1
    • Component/s: Command Line
    • Labels:
      None
    • Complexity:
      Intermediate
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      Printing a platform's locale and file encoding might be worth to add when Maven is requested to show version information since these parameters can affect text/string handling code.

        Issue Links

          Activity

          Hide
          Herve Boutemy added a comment -

          fixed in trunk r647626 and 2.0.x branch r647627

          Show
          Herve Boutemy added a comment - fixed in trunk r647626 and 2.0.x branch r647627
          Hide
          Paul Benedict added a comment -

          I am concerned about the kind of non-Maven properties outputed with the version. It sounds like it could grow pretty big based on feature requests. Why not just provide an extended debug option that dumps all the JVM properties?

          Show
          Paul Benedict added a comment - I am concerned about the kind of non-Maven properties outputed with the version. It sounds like it could grow pretty big based on feature requests. Why not just provide an extended debug option that dumps all the JVM properties?
          Hide
          Herve Boutemy added a comment -

          I understand that anything should not be outputted
          The dump of every properties gives a really huge result, which is already available in Surefiire XML output: ading an option for it isn't useful IMHO

          Before the change "mvn -v" outputs 3 lines: Maven version, JVM version and OS info.
          After the line, there is one more line with encoding and locale info: they are strategic properties, like JVM and OS.
          I think it's worth the extra line, and fits into "carefully chosen properties" category.

          Show
          Herve Boutemy added a comment - I understand that anything should not be outputted The dump of every properties gives a really huge result, which is already available in Surefiire XML output: ading an option for it isn't useful IMHO Before the change "mvn -v" outputs 3 lines: Maven version, JVM version and OS info. After the line, there is one more line with encoding and locale info: they are strategic properties, like JVM and OS. I think it's worth the extra line, and fits into "carefully chosen properties" category.
          Hide
          Paul Benedict added a comment - - edited

          What about an option that accepts a simple wildcard expression to match against system property names? Then you could give up on the feature requests and let the user filter himself:

          mvn -v -Zjava.locale.*,com.ibm.*

          where -Z is the placeholder for a new option.

          Show
          Paul Benedict added a comment - - edited What about an option that accepts a simple wildcard expression to match against system property names? Then you could give up on the feature requests and let the user filter himself: mvn -v -Zjava.locale.*,com.ibm.* where -Z is the placeholder for a new option.
          Hide
          brianfox brianfox added a comment -

          I agree with Herve's change, adding the locale is logical, making it more complicated to dump system properties is not warranted.

          Show
          brianfox brianfox added a comment - I agree with Herve's change, adding the locale is logical, making it more complicated to dump system properties is not warranted.
          Hide
          Dennis Lundberg added a comment -

          I agree as well. One rationale behind the change is to make it easy for a user to fetch the most important properties about the users environment. The properties that can help developers trying to solve an issue. The properties that have historically been known to mess things up, if not properly configured.

          Show
          Dennis Lundberg added a comment - I agree as well. One rationale behind the change is to make it easy for a user to fetch the most important properties about the users environment. The properties that can help developers trying to solve an issue. The properties that have historically been known to mess things up, if not properly configured.
          Hide
          John Casey added a comment -

          Adding fix-for for both 2.0.10 and 2.1.0-M1, since 2.1.0-M1 will actually be released first and may not incorporate all of the eventual issue fixes released in 2.0.10.

          Show
          John Casey added a comment - Adding fix-for for both 2.0.10 and 2.1.0-M1, since 2.1.0-M1 will actually be released first and may not incorporate all of the eventual issue fixes released in 2.0.10.
          Hide
          Benjamin Bentmann added a comment -

          Was lost in r688884 and restored in r744991.

          Show
          Benjamin Bentmann added a comment - Was lost in r688884 and restored in r744991 .

            People

            • Assignee:
              Herve Boutemy
              Reporter:
              Benjamin Bentmann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: