Maven 2 & 3

Shade MX* classes from plexus-utils

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.8
  • Fix Version/s: 2.0.10, 2.1.0, 3.0-alpha-1
  • Component/s: None
  • Labels:
    None
  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

The Maven uber JAR currently ships with unshaded MXParser and MXSerializer, preventing plugins from using their recent implementations from plexus-utils. My initial question on the dev list showed now immediate objections and the core ITs also smile so here we go with the proposed patch.

  1. Text File
    shade-mx-classes.patch
    05/Apr/08 9:19 AM
    0.8 kB
    Benjamin Bentmann
  2. Text File
    shade-mx-classes-addon.patch
    16/Jul/08 1:16 PM
    1 kB
    Benjamin Bentmann

Issue Links

is depended upon by

Sub-task - The sub-task of the issue MNG-3829 3.0-alpha-1 release: get the core ITs passing

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Improvement - An improvement or enhancement to an existing feature or task. MNG-2892 Use shade to hide the use of plexus-utils internally so that plugins can use their own version

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-3668 maven-eclipse-plugin 2.5 is failing with java.lang.LinkageError

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Casey added a comment -

Pushing to 2.0.11 so we can have a smaller set of high-value issues to target for the next release (2.0.10).

Show
John Casey added a comment - Pushing to 2.0.11 so we can have a smaller set of high-value issues to target for the next release (2.0.10).
Hide
Permalink
John Casey added a comment -

I'll try to get this in too.

Show
John Casey added a comment - I'll try to get this in too.
Hide
Permalink
John Casey added a comment -

When building a POM project with a site descriptor, this change causes a linkage error on XmlSerializer (from Xpp3Dom). Looking around on the java forums, I found this:

http://forum.java.sun.com/thread.jspa?messageID=3902289

which seems to hint that processing the Xpp3Dom class to change package names for anything at all might cause this problem. I'm not entirely sure I understand this problem, but I'm adding a new IT to the core-integration-tests to check this scenario for future changes.

Unfortunately, this issue won't make it into 2.0.10 as a result. This problem seems to indicate a level of risk for this change that I'm simply uncomfortable with at this stage.

Show
John Casey added a comment - When building a POM project with a site descriptor, this change causes a linkage error on XmlSerializer (from Xpp3Dom). Looking around on the java forums, I found this: http://forum.java.sun.com/thread.jspa?messageID=3902289 which seems to hint that processing the Xpp3Dom class to change package names for anything at all might cause this problem. I'm not entirely sure I understand this problem, but I'm adding a new IT to the core-integration-tests to check this scenario for future changes. Unfortunately, this issue won't make it into 2.0.10 as a result. This problem seems to indicate a level of risk for this change that I'm simply uncomfortable with at this stage.
Hide
Permalink
John Casey added a comment -

pushing to 2.0.11, and I'll revert this change in trunk until we have a solution.

Show
John Casey added a comment - pushing to 2.0.11, and I'll revert this change in trunk until we have a solution.
Hide
Permalink
Benjamin Bentmann added a comment -

Adding the attached patch makes the IT pass for me (both with Shade 1.0.1 and 1.2-SNAPSHOT).

As described on the dev@, once we refine the exclusions, the Shade Plugin will cause damage to the package imports in DefaultPluginManager. Refining these imports, too, seems functional.

Show
Benjamin Bentmann added a comment - Adding the attached patch makes the IT pass for me (both with Shade 1.0.1 and 1.2-SNAPSHOT). As described on the dev@ , once we refine the exclusions, the Shade Plugin will cause damage to the package imports in DefaultPluginManager . Refining these imports, too, seems functional.
Hide
Permalink
Brett Porter added a comment -

reapplied to 2.0.10, and rewrote the integration test to both verify the original fix, and a more specific test for the linkage error that was being seen rather than just using the site plugin

Show
Brett Porter added a comment - reapplied to 2.0.10, and rewrote the integration test to both verify the original fix, and a more specific test for the linkage error that was being seen rather than just using the site plugin

People

  • Assignee:
    Brett Porter
    Reporter:
    Benjamin Bentmann
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: