Maven 2 & 3

regression : <dependency> in plugin configuration doesn't override plugin classpath

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0.8
  • Fix Version/s: 2.0.9
  • Component/s: Plugin API
  • Labels:
    None
  • Number of attachments :
    0

Description

Many maven plugins are wrapper around other tools. The plugin is designed for a version of the tool, and in many case user will want to use a specific version without having to patch the plugin. The <dependency> element on plugin configuration is a common way to do this, by overriding the plugin POM dependency with another version.

<plugin>
<artifactId>castor-maven-plugin</artifactId>
<dependencies>
<dependency>
<groupId>org.codehaus.castor</groupId>
<artifactId>castor</artifactId>
<version>VERSION OF CASTOR I WANT TO USE FOR CODE GENERATION</version>
</dependency>
</dependencies>
</plugin>

This used to work with maven < 2.0.8

In maven 2.0.8, this doesn't work anymore as the <dependency> set in plugin configuration is added to plugin classpath, as a duplicate for the one declared by the plugin but LATER in the classpath (but I may be wrong on this analysis).

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MNG-2972 Ignores version of plugin dependency specified in my pom

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-3473 site generation with 2.0.9 and plugin:report (2.4 ONLY) is broken

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. MNG-3119 Duplicate attached artifacts should not be allowed.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

Hi nicolas - are you working on this yourself?

If you have a test case, I'd like to ensure we get this in to 2.0.9.

Show
Brett Porter added a comment - Hi nicolas - are you working on this yourself? If you have a test case, I'd like to ensure we get this in to 2.0.9.
Hide
Permalink
nicolas de loof added a comment -

Yes, I plan to both provide a test case and investigate to fix this in 2.0.9.

Show
nicolas de loof added a comment - Yes, I plan to both provide a test case and investigate to fix this in 2.0.9.
Hide
Permalink
nicolas de loof added a comment -

testcase committed in maven\core-integration-testing\core-integration-tests
testcase uses castor-maven-plugin as castor codegen includes castor version in generated files header
on maven 2.0.8, generated code is always for 1.1.2.1, as specified by plugin dependencies, even when <dependency> is set on plugin configuration.

Show
nicolas de loof added a comment - testcase committed in maven\core-integration-testing\core-integration-tests testcase uses castor-maven-plugin as castor codegen includes castor version in generated files header on maven 2.0.8, generated code is always for 1.1.2.1, as specified by plugin dependencies, even when <dependency> is set on plugin configuration.
Hide
Permalink
nicolas de loof added a comment -

Use a LinkedHashSet to make plugin dependencies ordering predictable (same as maven 2.1) and place project.build.plugin.dependencies prior to plugin POM dependencies

Show
nicolas de loof added a comment - Use a LinkedHashSet to make plugin dependencies ordering predictable (same as maven 2.1) and place project.build.plugin.dependencies prior to plugin POM dependencies
Hide
Permalink
Brian Fox added a comment -

This issue causes MNG-3473. Reverting the change in v633014 causes the tests to pass.

Show
Brian Fox added a comment - This issue causes MNG-3473 . Reverting the change in v633014 causes the tests to pass.
Hide
Permalink
Paul Benedict added a comment -

I know MNG-3473 was reverted, but why since 2.0.9 is all about increasing stability? It seems, in my opinion, that these two should be solved together. If this is about timing, I don't see a critical need to push out 2.0.9 soon. Just my 2 cents.

Show
Paul Benedict added a comment - I know MNG-3473 was reverted, but why since 2.0.9 is all about increasing stability? It seems, in my opinion, that these two should be solved together. If this is about timing, I don't see a critical need to push out 2.0.9 soon. Just my 2 cents.
Hide
Permalink
John Casey added a comment -

The move to use LinkedHashSet was definitely correct IMO, but it led to some weird side effects for dependency ordering. I've gone back and added a pre-processing step using a LinkedHashMap to merge in the plugin-level dependencies and those from the plugin-POM itself. I kept the plugin-level deps as first to be added, which gives them precedence (so they can replace dependencies from the plugin POM), but added code to make sure any duplicates according to dependencyConflictId are avoided. This is consistent with dependencies in the POM, where duplicates there should lead to a model validation exception during project building.

I think this issue can safely be put to bed now.

Show
John Casey added a comment - The move to use LinkedHashSet was definitely correct IMO, but it led to some weird side effects for dependency ordering. I've gone back and added a pre-processing step using a LinkedHashMap to merge in the plugin-level dependencies and those from the plugin-POM itself. I kept the plugin-level deps as first to be added, which gives them precedence (so they can replace dependencies from the plugin POM), but added code to make sure any duplicates according to dependencyConflictId are avoided. This is consistent with dependencies in the POM, where duplicates there should lead to a model validation exception during project building. I think this issue can safely be put to bed now.

People

  • Assignee:
    John Casey
    Reporter:
    nicolas de loof
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: