Maven 2 & 3

Transfer errors cause junk metadata in the local repo

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.8
  • Fix Version/s: 2.0.9
  • Component/s: Artifacts and Repositories
  • Labels:
    None
  • Number of attachments :
    1

Description

I see this all the time and I swear there was an issue for it, but now I can't find it. Sometimes there is metadata in the repo, usually after an offline build or a build where something went wrong downloading artifacts. Maven will apparently decide based on the metadata that the file can never be found and will simply fail on a missing artifact. You can tell this has happened because no attempt has actually been made to download the artifact from a repository. Subsequent clearing of (portions) the localrepo fixes the issue. This is terribly confusing to new users...and annoying to everyone.

Issue Links

This issue duplicates:
MNG-3399 Maven shows fake network error until the next updatePolicy period Major Closed
This issue is duplicated by:
MNG-2941 Sometime SNAPSHOTs can not be downloaded in an an online build Major Closed
This issue relates to:
MNG-3411 got the error like(Searching repository for plugin with prefix: 'archetype',repository is black listed,The plugin 'org.apache.maven.plugins:maven-archetype-plugin' does not exits) Blocker Closed
This issue is related to:
MNG-1320 Build failed due to an empty or corrupt metadata file in the repository Major Closed
MNG-3312 Maven creates empty plugin metadata during offline mode, causing successive online builds to fail Major Closed
MNG-2712 update policy 'daily' not honored Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

no time to test it today - but I think this patch would resolve this issue

Show
Brett Porter added a comment - no time to test it today - but I think this patch would resolve this issue
Hide
Permalink
Brett Porter added a comment -

using MNG-3341's IT as a basis should make it pretty easy to reproduce (just use an invalid wagon to trigger the error). However, what really needs to be rechecked is that no other metadata operations break as a result (most particularly, you don't want to end up downloading missing metadata every time if it doesn't exist)

Show
Brett Porter added a comment - using MNG-3341's IT as a basis should make it pretty easy to reproduce (just use an invalid wagon to trigger the error). However, what really needs to be rechecked is that no other metadata operations break as a result (most particularly, you don't want to end up downloading missing metadata every time if it doesn't exist)
Hide
Permalink
John Casey added a comment -

I have the fix in place on my localhost, but I'm still trying to nail down the integration tests and make them work in both 2.0.9 and 2.1. It'll be Monday before I get this sorted out.

Show
John Casey added a comment - I have the fix in place on my localhost, but I'm still trying to nail down the integration tests and make them work in both 2.0.9 and 2.1. It'll be Monday before I get this sorted out.
Hide
Permalink
John Casey added a comment -

This issue is fixed. I applied Brett's patch (thanks for the heavy lifting here, Brett), and added integration tests to check writing the metadata on ResourceNotFoundException, but not on TransferFailedException.

NOTE: This integration test required a little extra functionality in the abstract parent test class, to allow conditional use of different files for the updateInterval calculation (we're making sure these files are not modified on successive builds when ResourceNotFoundException happens).

The integration test should be fairly well-documented, so have a look.

Show
John Casey added a comment - This issue is fixed. I applied Brett's patch (thanks for the heavy lifting here, Brett), and added integration tests to check writing the metadata on ResourceNotFoundException, but not on TransferFailedException. NOTE: This integration test required a little extra functionality in the abstract parent test class, to allow conditional use of different files for the updateInterval calculation (we're making sure these files are not modified on successive builds when ResourceNotFoundException happens). The integration test should be fairly well-documented, so have a look.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.