[#MNG-3415] Transfer errors cause junk metadata in the local repo

Maven 2

Transfer errors cause junk metadata in the local repo

Created: 21/Feb/08 08:59 AM Updated: 10/Mar/08 12:41 PM

Component/s:

Artifacts and Repositories

Affects Version/s:

2.0.8

Fix Version/s:

2.0.9

Time Tracking:

Not Specified

File Attachments:

MNG-3415.diff (5 kB)

Issue Links:

Duplicate

This issue duplicates:

~~MNG-3399~~ Maven shows fake network error until the next updatePolicy period

Related

This issue relates to:

~~MNG-3411~~ got the error like(Searching repository for plugin with prefix: 'archetype',repository is black listed,The plugin 'org.apache.maven.plugins:maven-archetype-plugin' does not exits)

This issue is related to:

~~MNG-1320~~ Build failed due to an empty or corrupt metadata file in the repository

~~MNG-3312~~ Maven creates empty plugin metadata during offline mode, causing successive online builds to fail

Description

« Hide

I see this all the time and I swear there was an issue for it, but now I can't find it. Sometimes there is metadata in the repo, usually after an offline build or a build where something went wrong downloading artifacts. Maven will apparently decide based on the metadata that the file can never be found and will simply fail on a missing artifact. You can tell this has happened because no attempt has actually been made to download the artifact from a repository. Subsequent clearing of (portions) the localrepo fixes the issue. This is terribly confusing to new users...and annoying to everyone.

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

Brett Porter added a comment - 05/Mar/08 08:41 PM

no time to test it today - but I think this patch would resolve this issue

[ Permalink | « Hide ]

Brett Porter added a comment - 05/Mar/08 08:43 PM

using ~~MNG-3341~~'s IT as a basis should make it pretty easy to reproduce (just use an invalid wagon to trigger the error). However, what really needs to be rechecked is that no other metadata operations break as a result (most particularly, you don't want to end up downloading missing metadata every time if it doesn't exist)

[ Permalink | « Hide ]

John Casey added a comment - 07/Mar/08 10:17 PM

I have the fix in place on my localhost, but I'm still trying to nail down the integration tests and make them work in both 2.0.9 and 2.1. It'll be Monday before I get this sorted out.

[ Permalink | « Hide ]

John Casey added a comment - 10/Mar/08 12:41 PM

This issue is fixed. I applied Brett's patch (thanks for the heavy lifting here, Brett), and added integration tests to check writing the metadata on ResourceNotFoundException, but not on TransferFailedException.

NOTE: This integration test required a little extra functionality in the abstract parent test class, to allow conditional use of different files for the updateInterval calculation (we're making sure these files are not modified on successive builds when ResourceNotFoundException happens).

The integration test should be fairly well-documented, so have a look.