Maven 2 & 3

maven-model RepositoryBase overrides equals() but not hashCode()

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.7
  • Fix Version/s: 2.2.2, 3.0-alpha-6
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

Overriding equals and not hashCode is considered bad practice. Also, while looking around, I noticed the two subclasses (Repository and PluginRepository) both override equals and just call "super.equals()". There is a cryptic comment nearby that leads me to believe this is a temporary fix for an old problem.

  1. Text File
    MNG-3266-maven-model.patch
    30/Oct/07 5:35 PM
    2 kB
    Jared Roberts
  2. Text File
    MNG-3266-maven-model-v2.patch
    05/Nov/07 4:04 PM
    3 kB
    Jared Roberts

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-2817 Add identity specification in maven-model and maven-settings

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jared Roberts added a comment -

This patch implements hashCode() and also removes the subclasses' overrides of equals.

Show
Jared Roberts added a comment - This patch implements hashCode() and also removes the subclasses' overrides of equals.
Hide
Permalink
Jared Roberts added a comment -

The first version of this patch had a NPE in hashCode() since "217 + null != null". I opted to just use the <identifier> tag instead of implementing these methods.

Show
Jared Roberts added a comment - The first version of this patch had a NPE in hashCode() since "217 + null != null". I opted to just use the <identifier> tag instead of implementing these methods.
Hide
Permalink
Vincent Siveton added a comment -

should be fixed by MNG-2817

Show
Vincent Siveton added a comment - should be fixed by MNG-2817
Hide
Permalink
Herve Boutemy added a comment -

patch applied in r895088 for 2.2.x branch and r895089 for 3.0.x
thank you

Show
Herve Boutemy added a comment - patch applied in r895088 for 2.2.x branch and r895089 for 3.0.x thank you

People

  • Assignee:
    Herve Boutemy
    Reporter:
    Jared Roberts
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: