Maven 2 & 3

maven-model Extension.equals causes NPE when any field is uninitialized

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.7
  • Fix Version/s: 2.2.1, 3.0-alpha-3
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The equals(Object) method of Extension does not check for null values before calling String.equals().

Issue Links

This issue is related to:
MNG-2817 Add identity specification in maven-model and maven-settings Major Closed
MNG-3921 Extensions are subject to NPEs in their hashCode() impl Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jared Roberts added a comment -

This patch should take care of it.

Show
Jared Roberts added a comment - This patch should take care of it.
Hide
Permalink
Jared Roberts added a comment -

That's what I get for copying and pasting... The title should be" Extension.equals causes NPE" not "Repository".

Show
Jared Roberts added a comment - That's what I get for copying and pasting... The title should be" Extension.equals causes NPE" not "Repository".
Hide
Permalink
Vincent Siveton added a comment -

should be fixed by MNG-2817

Show
Vincent Siveton added a comment - should be fixed by MNG-2817
Hide
Permalink
Brett Porter added a comment -

patch to review, similar to recently fixed bug in 2.0.10

Show
Brett Porter added a comment - patch to review, similar to recently fixed bug in 2.0.10
Hide
Permalink
Benjamin Bentmann added a comment -

Fixed in r793311 and r793319, respectively.

Show
Benjamin Bentmann added a comment - Fixed in r793311 and r793319, respectively.

People

Vote (2)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.