Maven 2 & 3

maven should execute compiler:compile and :test-compile in separate executions, to allow separate configuration

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.7
  • Fix Version/s: 2.2.0
  • Component/s: Plugins and Lifecycle
  • Labels:
    None
  • Number of attachments :
    0

Description

Currently, it's impossible to configure the two default maven-compiler-plugin mojos in the jar lifecycle (:compile and :test-compile) separately without the configuration for one affecting both. This is because they are both executed in the same (default) execution. We should be assigning these to different execution id's, to allow separate configuration.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MCOMPILER-15 ability to have different test compilation parameters to general compilation parameters

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-3401 Plugin parameters must be specified outside an execution block when they are invoked from the command line

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-4919 Plugin execution contributed by lifecycle mapping gets lost when same goal is bound multiple times

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
John Casey made changes -
Field Original Value New Value
Fix Version/s 2.1-alpha-1 [ 13143 ]
Fix Version/s 2.0.8 [ 13139 ]
Hide
Permalink
Brett Porter added a comment -

I'm not sure what you mean here - how would this be used? Maybe something like:

<configuration>
<shared>...</shared>
</configuration>
<executions>
<execution>
<id>testCompile</id>
<configuration>
<something>...
</configuration>
<!-- not goals, that's already bound -->
</execution>
</executions>

I'm not even sure that'd work - could be a good way to achieve this though. Would you implement it by putting every bound goal in it's own execution? Currently, there is no way to specify this in the default lifecycles.

Show
Brett Porter added a comment - I'm not sure what you mean here - how would this be used? Maybe something like: <configuration> <shared>...</shared> </configuration> <executions> <execution> <id>testCompile</id> <configuration> <something>... </configuration> <!-- not goals, that's already bound --> </execution> </executions> I'm not even sure that'd work - could be a good way to achieve this though. Would you implement it by putting every bound goal in it's own execution? Currently, there is no way to specify this in the default lifecycles.
Brett Porter made changes -
Link This issue relates to MCOMPILER-15 [ MCOMPILER-15 ]
Hide
Permalink
Brian Fox added a comment -

bumping to 2.0.9. If we get IT tests for these before 2.0.8 is final, we can take a look

Show
Brian Fox added a comment - bumping to 2.0.9. If we get IT tests for these before 2.0.8 is final, we can take a look
Brian Fox made changes -
Fix Version/s 2.1-alpha-1 [ 13143 ]
Fix Version/s 2.0.9 [ 13801 ]
Fix Version/s 2.0.8 [ 13139 ]
Brian Fox made changes -
Fix Version/s 2.0.10 [ 14112 ]
Fix Version/s 2.0.9 [ 13801 ]
Hide
Permalink
John Casey added a comment -

Pushing to 2.0.11 so we can have a smaller set of high-value issues to target for the next release (2.0.10).

Show
John Casey added a comment - Pushing to 2.0.11 so we can have a smaller set of high-value issues to target for the next release (2.0.10).
John Casey made changes -
Fix Version/s 2.0.11 [ 14118 ]
Fix Version/s 2.0.10 [ 14112 ]
Benjamin Bentmann made changes -
Link This issue relates to MNG-3401 [ MNG-3401 ]
Hide
Permalink
John Casey added a comment -

for default lifecycle bindings (mojos bound to the lifecycle from the packaging of the POM), the executionId that can be used to configure each is 'default-<goalname>'. So, to configure the compiler plugin differently for the compile and testCompile goals, you'd use something like:

<plugin>
  <artifactId>maven-compiler-plugin</artifactId>
  <executions>
    <execution>
      <id>default-compile</id>
      <configuration>
        <source>1.4</source>
        <target>1.4</target>
      </configuration>
    </execution>
    <execution>
      <id>default-testCompile</id>
      <configuration>
        <source>1.5</source>
        <target>1.5</target>
      </configuration>
    </execution>
  </executions>
</plugin>

This should work both in Maven 2.2.0 and in Maven 3.x. See IT:

MavenITmng3203DefaultLifecycleExecIdTest.java

Show
John Casey added a comment - for default lifecycle bindings (mojos bound to the lifecycle from the packaging of the POM), the executionId that can be used to configure each is 'default-<goalname>'. So, to configure the compiler plugin differently for the compile and testCompile goals, you'd use something like: <plugin> <artifactId> maven-compiler-plugin </artifactId> <executions> <execution> <id> default-compile </id> <configuration> <source> 1.4 </source> <target> 1.4 </target> </configuration> </execution> <execution> <id> default-testCompile </id> <configuration> <source> 1.5 </source> <target> 1.5 </target> </configuration> </execution> </executions> </plugin> This should work both in Maven 2.2.0 and in Maven 3.x. See IT: MavenITmng3203DefaultLifecycleExecIdTest.java
John Casey made changes -
Resolution Fixed [ 1 ]
Fix Version/s 2.0.11 [ 14118 ]
Assignee John Casey [ jdcasey ]
Fix Version/s 2.2.0 [ 15103 ]
Status Open [ 1 ] Closed [ 6 ]
Benjamin Bentmann made changes -
Link This issue relates to MNG-4919 [ MNG-4919 ]

People

  • Assignee:
    John Casey
    Reporter:
    John Casey
Vote (5)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: