Maven 2 & 3

No component for RAR packaging projects in components.xml

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 2.0.6
  • Fix Version/s: 2.0.8
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    0

Description

For a project with packaging "rar" the codehaus maven plugin for Cobertura does not work.
During instrumentation the following message is displayed:

"Not executing cobertura:instrument as the project is not a Java classpath-capable package"

The reason for this is that in the CoberturaInstrumentMojo.execute() the code checks which language that the artifact is implemented in, like this:
ArtifactHandler artifactHandler = project.getArtifact().getArtifactHandler();
if ( !"java".equals( artifactHandler.getLanguage() ) )

{ getLog().info( "Not executing cobertura:instrument as the project is not a Java classpath-capable package" ); }

Looking at the components.xml in the Maven sources, we find that the "rar" packaging is not specified at all, meaning that it will be handled with the DefaultArtifactHandler and all properties set to null, including the language property.
This can be fixed with the following addition to components.xml:

<components>
....
<component>
<role>org.apache.maven.artifact.handler.ArtifactHandler</role>
<role-hint>rar</role-hint>
<implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation>
<configuration>
<type>rar</type>
<extension>rar</extension>
<includesDependencies>true</includesDependencies>
<language>java</language>
<addedToClasspath>false</addedToClasspath>
</configuration>
</component>
...
</components>

Issue Links

Activity

Hide
John Casey added a comment -

Why is this cloned?

Show
John Casey added a comment - Why is this cloned?
Hide
John Casey added a comment -

As I mentioned in the linked issue, I believe this should be defined in the maven-rar-plugin, then used via <plugin><extensions>true</></>

Show
John Casey added a comment - As I mentioned in the linked issue, I believe this should be defined in the maven-rar-plugin, then used via <plugin><extensions>true</></>
Hide
Peter Liljenberg added a comment -
Show
Peter Liljenberg added a comment - MRAR-17
Hide
Herve Boutemy added a comment -

done in r593857 see http://svn.apache.org/viewvc?view=rev&revision=593857

not precisely the same configuration as proposed here

Show
Herve Boutemy added a comment - done in r593857 see http://svn.apache.org/viewvc?view=rev&revision=593857 not precisely the same configuration as proposed here

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: