Maven 2 & 3

DefaultModelInheritence::assembleDistributionInheritence should be childPathAdjustment aware

Details

  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

In the same way that the URL, and SCM inheritance assembly is 'childPathAdjustment' aware, so should the site distribution URL.

The childPathAdjustment value takes into account a child's relative location to its parent, such that 'children' (modules) that are declared via <module>../../foo/bar</module> end up with paths that are accurate for their location within the external namespaces (ie the SCM namespace or the URL namespace). However this is not being done for the site distribution URL which is obviously a bug as the project URL, which remember is childPathAdjustment aware, has a direct coupling to the distroManagement.site.URL.

Patch against maven-project 2.0.7 attached.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MNG-2209 Calculation of module URLs does not match deployment

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-2006 Module SCM URL is resolved as [...]/parent/module regardless of relativePath

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. MNG-2290 Generated URLs in POMs of child modules

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-5000 [regression] child distributionManagment.site.url not correct in a flat directory layout when child's artifactId doesn't match its module name

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-3848 [regression] Inheritance of project/site/scm URLs does not take child's relative location to parent into account

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-4994 [regression] Inheritance of project/site/scm URLs does not take child's relative location to parent into account

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Hide
Permalink
John Casey added a comment -

Applied. Thanks, John.

Show
John Casey added a comment - Applied. Thanks, John.

People

  • Assignee:
    John Casey
    Reporter:
    John Allen
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: