Maven 2 & 3

Reactor projects should be included in dependency resolution

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.7
  • Fix Version/s: 2.1.0
  • Component/s: Dependencies
  • Labels:
    None
  • Complexity:
    Intermediate
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

Dependency resolution for mojos with @requiresDependencyResolution should include the projects within the reactor. See attached it0122 for an example (numbered as such due to MNG-2994's it0121).

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-2277 aggregating plugins in submodules of the reactor return all projects causing a chicken/egg issue

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MJAVADOC-116 Impossible to aggregate javadoc if snapshot never built

  • Major - Major loss of function.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Bug - A problem which impairs or prevents the functions of the product. MNG-3043 Allow 'mvn test' to work with test-jar dependencies in a reactor

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-240 release-pom.xml does not contain <dependencies> and <dependencyManagement>

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

will review patch for 2.0.7 since it has a test and all

Show
Brett Porter added a comment - will review patch for 2.0.7 since it has a test and all
Hide
Permalink
Brett Porter added a comment -

my bad, it's just the test - no fix yet.

Show
Brett Porter added a comment - my bad, it's just the test - no fix yet.
Hide
Permalink
Brett Porter added a comment -

patch applied for test

Show
Brett Porter added a comment - patch applied for test
Hide
Permalink
sleberrig added a comment -

This sounds like a critical issue to me. It is impossible to work with multi-module projects if dependencies resolution goes to the repositories instead of the reactor. An good example of this is working with the release plugin (version 2.0-beta-7 IIRC):

1. I do a clean checkout on a build server,
2. I run mvn release:prepare

And as release:prepare relies on the @requiresDependencyResolution, it fails because the SNAPSHOT is not installed locally.

Show
sleberrig added a comment - This sounds like a critical issue to me. It is impossible to work with multi-module projects if dependencies resolution goes to the repositories instead of the reactor. An good example of this is working with the release plugin (version 2.0-beta-7 IIRC): 1. I do a clean checkout on a build server, 2. I run mvn release:prepare And as release:prepare relies on the @requiresDependencyResolution, it fails because the SNAPSHOT is not installed locally.
Hide
Permalink
Brett Porter added a comment -

this constantly proves a nuisance - worth reviewing

Show
Brett Porter added a comment - this constantly proves a nuisance - worth reviewing
Hide
Permalink
John Casey added a comment -

Consolidating to 2.1.0-M1 so we can then rename to 2.1.0. We can weed out any issues we want to push to a later release from this set once we've done the consolidation.

Show
John Casey added a comment - Consolidating to 2.1.0-M1 so we can then rename to 2.1.0. We can weed out any issues we want to push to a later release from this set once we've done the consolidation.
Hide
Permalink
Zac Thompson added a comment - - edited

I still see this behaviour in 2.1.0. (Samuel's example above)

... update: actually, I think this is because of a test dependency, which is posted as a different issue. My apologies!

Show
Zac Thompson added a comment - - edited I still see this behaviour in 2.1.0. (Samuel's example above) ... update: actually, I think this is because of a test dependency, which is posted as a different issue. My apologies!

People

  • Assignee:
    John Casey
    Reporter:
    Mark Hobson
Vote (0)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved: