Maven 2 & 3

pluginManagement configurations are not honoured when plugin is silently included

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.0-alpha-1
  • Fix Version/s: 3.0-alpha-3
  • Component/s: Embedding
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

Read http://jira.codehaus.org/browse/MEVENIDE-532

In my top parent pom.xml i've define the maven-compiler-plugin configuration like:

<build>
<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.5</source>
<target>1.5</target>
<encoding>UTF-8</encoding>
</configuration>
</plugin> ...

since not all my subprojects require the plugin, and when they do they silently include the plugin, it makes more sense to define it within the <pluginManagement> tag.
But when i use mevenide-netbeans all my projects are marked uncompilable since the maven embedder does not report the above defined configuration for the maven-compiler-plugin.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-522 pluginManagement doesn't inject source and target into maven-compiler-plugin

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Milos Kleint added a comment -

the netbeans integration is using a maven-embedder 2.1-SNAPSHOT from last September.

Show
Milos Kleint added a comment - the netbeans integration is using a maven-embedder 2.1-SNAPSHOT from last September.
Hide
Permalink
Jason van Zyl added a comment -

Please provide a POM we can reproduce the problem with. I can try with the CLI and the embedder but only when I have somethign to work with.

Show
Jason van Zyl added a comment - Please provide a POM we can reproduce the problem with. I can try with the CLI and the embedder but only when I have somethign to work with.
Hide
Permalink
Michael Semb Wever added a comment -

The above snippet is enough to put into the pom.xml, along with a <modules><module>... for a child project.
Given that the parent project does not have java sources, and the child project does, step into the child project and build.
It should builds ok, with the settings as defined under the parent's pluginManagement for maven-compiler-plugin.
This is because the maven-compiler-plugin is included by default when you compile java sources, and when it is installed by default it sucks in the settings defined within the pluginManagement.

Now, instead of building, run/debug the embedder to output the child's pom (or however the embedder works to extract this information) and you'll see that the maven-compiler-plugin settings are not "sucked in".

Reading the original issue, http://jira.codehaus.org/browse/MEVENIDE-532 , goes through the original issue report at a more user-level, since i originally thought the problem was in the netbeans maven-project implementation, but the author there reported that it's actually the maven embedder which is not extracting the information defined it pluginManagement.

If i change pluginManagement to just plugins then it works correctly, but every plugin listed within plugins is therefore loaded into each subprojects maven build process, yuk.

Show
Michael Semb Wever added a comment - The above snippet is enough to put into the pom.xml, along with a <modules><module>... for a child project. Given that the parent project does not have java sources, and the child project does, step into the child project and build. It should builds ok, with the settings as defined under the parent's pluginManagement for maven-compiler-plugin. This is because the maven-compiler-plugin is included by default when you compile java sources, and when it is installed by default it sucks in the settings defined within the pluginManagement. Now, instead of building, run/debug the embedder to output the child's pom (or however the embedder works to extract this information) and you'll see that the maven-compiler-plugin settings are not "sucked in". Reading the original issue, http://jira.codehaus.org/browse/MEVENIDE-532 , goes through the original issue report at a more user-level, since i originally thought the problem was in the netbeans maven-project implementation, but the author there reported that it's actually the maven embedder which is not extracting the information defined it pluginManagement. If i change pluginManagement to just plugins then it works correctly, but every plugin listed within plugins is therefore loaded into each subprojects maven build process, yuk.
Hide
Permalink
Michael Semb Wever added a comment -

TestCase Available.

Checkout http://sesat.no/svn/sesat-kernel/trunk
and uncomment the lines
<Unable to render embedded object: File (--pluginManagement--> <) not found.-- See http://jira.codehaus.org/browse/MNG-3018 .Uncomment when fixed. -->
and
<Unable to render embedded object: File (--/pluginManagement--> <) not found.-- See http://jira.codehaus.org/browse/MNG-3018 .Uncomment when fixed. -->

to see an example.

Show
Michael Semb Wever added a comment - TestCase Available. Checkout http://sesat.no/svn/sesat-kernel/trunk and uncomment the lines < Unable to render embedded object: File (--pluginManagement--> <) not found. -- See http://jira.codehaus.org/browse/MNG-3018 .Uncomment when fixed. --> and < Unable to render embedded object: File (--/pluginManagement--> <) not found. -- See http://jira.codehaus.org/browse/MNG-3018 .Uncomment when fixed. --> to see an example.
Hide
Permalink
Benjamin Bentmann added a comment -

This issue resembles MNG-522. The corresponding core IT passes with alpha-1, alpha-2 and trunk. So, if the Maven CLI uses the same code path as the embedder, this should be fixed.

Show
Benjamin Bentmann added a comment - This issue resembles MNG-522 . The corresponding core IT passes with alpha-1, alpha-2 and trunk. So, if the Maven CLI uses the same code path as the embedder, this should be fixed.
Hide
Permalink
Michael Semb Wever added a comment -

still broken for me.

Show
Michael Semb Wever added a comment - still broken for me.
Hide
Permalink
Benjamin Bentmann added a comment -

Both IT for MNG-522 and a UT confirm this to be fixed.

Show
Benjamin Bentmann added a comment - Both IT for MNG-522 and a UT confirm this to be fixed.

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Michael Semb Wever
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: