Maven 2 & 3

Snapshot repositories are not checked when using ranges

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.6
  • Fix Version/s: 3.0-beta-1
  • Component/s: Artifacts and Repositories
  • Labels:
    None
  • Environment:
    Windows XP, Cygwin
  • Complexity:
    Intermediate
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    4

Description

The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.

  1. Text File
    MNG-2994-2.patch
    07/Jun/07 7:19 AM
    7 kB
    Mark Hobson
  2. Text File
    MNG-2994-3.patch
    06/Jul/07 8:58 AM
    13 kB
    Mark Hobson
  3. Text File
    MNG-2994-core-it.patch
    06/Jul/07 9:12 AM
    2 kB
    Mark Hobson
  4. Text File
    patch.txt
    18/May/07 11:20 AM
    6 kB
    Mark Hobson

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. MNG-3092 Version ranges with non-snapshot bounds can contain snapshot versions

  • Major - Major loss of function.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MNG-2525 SNAPSHOT dependencies aren't found when repository has 'release' disabled and a version range is used

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-4295 version ranges are not resolved from snapshot only repositories

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-177 generateReleasePoms does not work

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-3376 plugin repositories are not checked when looking for snapshot plugin.

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark Hobson added a comment -

After stepping through, it's actually ArtifactRepositoryMetadata.isSnapshot always returning false when queried by DefaultRepositoryMetadataManager.resolve. In turn, this is called by MavenMetadataSource.retrieveAvailableVersions from DefaultArtifactCollector.recurse when artifact.getVersion() == null, i.e. when ranges are being used.

Show
Mark Hobson added a comment - After stepping through, it's actually ArtifactRepositoryMetadata.isSnapshot always returning false when queried by DefaultRepositoryMetadataManager.resolve. In turn, this is called by MavenMetadataSource.retrieveAvailableVersions from DefaultArtifactCollector.recurse when artifact.getVersion() == null, i.e. when ranges are being used.
Hide
Permalink
Brett Porter added a comment -

I'd suggest adding a method that is an alternate to isSnapshot that is capable of expressing the difference, and use that from the metadata manager (retains backwards compat too).

Show
Brett Porter added a comment - I'd suggest adding a method that is an alternate to isSnapshot that is capable of expressing the difference, and use that from the metadata manager (retains backwards compat too).
Hide
Permalink
Mark Hobson added a comment -

Updated IT patch to sync with current trunk by renaming it0121 to it0123 - please apply before someone adds another it0123!

Show
Mark Hobson added a comment - Updated IT patch to sync with current trunk by renaming it0121 to it0123 - please apply before someone adds another it0123!
Hide
Permalink
Mark Hobson added a comment -

Committed and commented-out attached it0123.

Show
Mark Hobson added a comment - Committed and commented-out attached it0123.
Hide
Permalink
Mark Hobson added a comment -

Attaching MNG-2994-3.patch which is a fix, rather than an IT.

Show
Mark Hobson added a comment - Attaching MNG-2994 -3.patch which is a fix, rather than an IT.
Hide
Permalink
Mark Hobson added a comment -

Attaching MNG-2994-core-it.patch that fixes it0043 in relation to this issue.

Show
Mark Hobson added a comment - Attaching MNG-2994 -core-it.patch that fixes it0043 in relation to this issue.
Hide
Permalink
John Casey added a comment -

This will need to wait until the other snapshots-in-version-ranges issue (referenced as a prerequisite for this issue) is resolved. Otherwise, we risk changing existing build behavior for version ranges in very bad ways.

Show
John Casey added a comment - This will need to wait until the other snapshots-in-version-ranges issue (referenced as a prerequisite for this issue) is resolved. Otherwise, we risk changing existing build behavior for version ranges in very bad ways.
Hide
Permalink
Benjamin Bentmann added a comment - - edited

Fixed in r932128.

In conformance with the fix for MNG-3092, snapshot repositories are now considered if any boundary of the version range explicitly refers to a snapshot.

Show
Benjamin Bentmann added a comment - - edited Fixed in r932128 . In conformance with the fix for MNG-3092 , snapshot repositories are now considered if any boundary of the version range explicitly refers to a snapshot.

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Mark Hobson
Vote (7)
Watch (11)

Dates

  • Created:
    Updated:
    Resolved: