Maven
  1. Maven
  2. MNG-2985

DefaultWagonManager does not safely remove TransferListeners from the wagon

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0-alpha-1
    • Fix Version/s: 3.0-alpha-1
    • Component/s: None
    • Labels:
      None
    • Environment:
      osx intel, java 5
    • Complexity:
      Intermediate
    • Number of attachments :
      3

      Description

      The method "getRemoteFile()" registers several transfer listeners, but never removes them.
      The method "putRemoteFile()" might left transfer listeners registered if an exception is raised.

      The results is that executing those method repeteadly continously increments the number of listeners. When embedded, the problem is specially relevant (see http://jira.codehaus.org/browse/MNGECLIPSE-302).

      Attached is a patch with test cases.

      1. MNG-2985-maven-artifact.patch
        10 kB
        Abel Muiņo
      2. MNG-2985-maven-artifact.patch
        8 kB
        Abel Muiņo
      3. MNG-2985-maven-artifact.with-license.patch
        11 kB
        Abel Muiņo

        Issue Links

          Activity

          Hide
          Abel Muiņo added a comment -

          Patch for the issue, with test cases.

          Show
          Abel Muiņo added a comment - Patch for the issue, with test cases.
          Abel Muiņo made changes -
          Field Original Value New Value
          Attachment MNG-2985-maven-artifact.patch [ 27284 ]
          Abel Muiņo made changes -
          Link This issue is depended upon by MNGECLIPSE-302 [ MNGECLIPSE-302 ]
          Hide
          Carlos Sanchez added a comment -

          you are missing Wagonnoop class in the patch

          Show
          Carlos Sanchez added a comment - you are missing Wagonnoop class in the patch
          Hide
          Abel Muiņo added a comment -

          Included WagonNoOp in the patch.

          Show
          Abel Muiņo added a comment - Included WagonNoOp in the patch.
          Abel Muiņo made changes -
          Attachment MNG-2985-maven-artifact.patch [ 27308 ]
          Hide
          Carlos Sanchez added a comment -

          just for legal reasons can you add the licnese header to WagonNoop as the other files have?

          Show
          Carlos Sanchez added a comment - just for legal reasons can you add the licnese header to WagonNoop as the other files have?
          Hide
          Abel Muiņo added a comment -

          License added.

          Show
          Abel Muiņo added a comment - License added.
          Abel Muiņo made changes -
          Hide
          Carlos Sanchez added a comment -

          Applied with some refactorings

          Show
          Carlos Sanchez added a comment - Applied with some refactorings
          Carlos Sanchez made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Fix Version/s 2.1-alpha-1 [ 13143 ]
          Resolution Fixed [ 1 ]
          Assignee Carlos Sanchez [ carlos ]

            People

            • Assignee:
              Carlos Sanchez
              Reporter:
              Abel Muiņo
            • Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: