Maven 2 & 3

DefaultWagonManager does not safely remove TransferListeners from the wagon

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.0-alpha-1
  • Fix Version/s: 3.0-alpha-1
  • Component/s: None
  • Labels:
    None
  • Environment:
    osx intel, java 5
  • Complexity:
    Intermediate
  • Number of attachments :
    3

Description

The method "getRemoteFile()" registers several transfer listeners, but never removes them.
The method "putRemoteFile()" might left transfer listeners registered if an exception is raised.

The results is that executing those method repeteadly continously increments the number of listeners. When embedded, the problem is specially relevant (see http://jira.codehaus.org/browse/MNGECLIPSE-302).

Attached is a patch with test cases.

Issue Links

This issue is depended upon by:
MNGECLIPSE-302 Plugin tries to download dependencies N times Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Abel Muiņo added a comment -

Patch for the issue, with test cases.

Show
Abel Muiņo added a comment - Patch for the issue, with test cases.
Hide
Permalink
Carlos Sanchez added a comment -

you are missing Wagonnoop class in the patch

Show
Carlos Sanchez added a comment - you are missing Wagonnoop class in the patch
Hide
Permalink
Abel Muiņo added a comment -

Included WagonNoOp in the patch.

Show
Abel Muiņo added a comment - Included WagonNoOp in the patch.
Hide
Permalink
Carlos Sanchez added a comment -

just for legal reasons can you add the licnese header to WagonNoop as the other files have?

Show
Carlos Sanchez added a comment - just for legal reasons can you add the licnese header to WagonNoop as the other files have?
Hide
Permalink
Abel Muiņo added a comment -

License added.

Show
Abel Muiņo added a comment - License added.
Hide
Permalink
Carlos Sanchez added a comment -

Applied with some refactorings

Show
Carlos Sanchez added a comment - Applied with some refactorings

People

Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.