Issue Details (XML | Word | Printable)

Key: MNG-2985
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Carlos Sanchez
Reporter: Abel Muiño
Votes: 2
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
Maven 2

DefaultWagonManager does not safely remove TransferListeners from the wagon

Created: 12/May/07 05:34 PM   Updated: 14/May/07 09:16 PM
Component/s: None
Affects Version/s: 3.0-alpha-1
Fix Version/s: 3.0-alpha-1

Time Tracking:
Not Specified

File Attachments: 1. Text File MNG-2985-maven-artifact.patch (10 kB)
2. Text File MNG-2985-maven-artifact.patch (8 kB)
3. Text File MNG-2985-maven-artifact.with-license.patch (11 kB)

Environment: osx intel, java 5
Issue Links:
dependent
 

Complexity: Intermediate


 Description  « Hide
The method "getRemoteFile()" registers several transfer listeners, but never removes them.
The method "putRemoteFile()" might left transfer listeners registered if an exception is raised.

The results is that executing those method repeteadly continously increments the number of listeners. When embedded, the problem is specially relevant (see http://jira.codehaus.org/browse/MNGECLIPSE-302).

Attached is a patch with test cases.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Abel Muiño added a comment - 12/May/07 05:37 PM
Patch for the issue, with test cases.

Carlos Sanchez added a comment - 13/May/07 11:00 PM
you are missing Wagonnoop class in the patch

Abel Muiño added a comment - 14/May/07 01:31 AM
Included WagonNoOp in the patch.

Carlos Sanchez added a comment - 14/May/07 06:36 PM
just for legal reasons can you add the licnese header to WagonNoop as the other files have?

Abel Muiño added a comment - 14/May/07 07:34 PM
License added.

Carlos Sanchez added a comment - 14/May/07 09:16 PM
Applied with some refactorings