mojo parameter validation should communicate expression

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-alpha-2
  • Component/s: Plugins and Lifecycle
  • Labels:
    None

Description

in the case where a mojo parameters is missing or incorrectly specified, and there was an expression given from the project we should translate it back to explain what was missing from the POM to the user.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Casey added a comment -

has this been fixed? See line 782 in DefaultPluginManager in maven-core...looks fixed to me.

Show
John Casey added a comment - has this been fixed? See line 782 in DefaultPluginManager in maven-core...looks fixed to me.
Hide
Permalink
Brett Porter added a comment -

the expression part is ok. What I was thinking of here was translating the expression back to something more identifiable with the section of the pom (if there is no expression, it should talk in terms of the <plugins/> section). It would also be worth handling failed sets in a similar way.

Show
Brett Porter added a comment - the expression part is ok. What I was thinking of here was translating the expression back to something more identifiable with the section of the pom (if there is no expression, it should talk in terms of the <plugins/> section). It would also be worth handling failed sets in a similar way.
Hide
Permalink
John Casey added a comment -

fixed via ErrorDiagnoser implementation (PluginConfigurationDiagnoser)

Show
John Casey added a comment - fixed via ErrorDiagnoser implementation (PluginConfigurationDiagnoser)
Hide
Permalink
Brett Porter added a comment -

verified

Show
Brett Porter added a comment - verified

People

  • Assignee:
    John Casey
    Reporter:
    Brett Porter
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: