Maven 2 & 3

versionrange doesn't handle singular version correctly

Details

  • Complexity:
    Novice
  • Testcase included:
    yes
  • Number of attachments :
    0

Description

I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.

The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix

I just need someone to take a look and I can apply.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brian Fox added a comment -

Ran IT tests before and after patch and the results are the same.

Only 1 failure:
0108SnapshotUpdate(testSnapshotLocalMetadataUpdatedOnInstall).. Failure

Show
Brian Fox added a comment - Ran IT tests before and after patch and the results are the same. Only 1 failure: 0108SnapshotUpdate(testSnapshotLocalMetadataUpdatedOnInstall).. Failure
Hide
Permalink
Jason van Zyl added a comment -

Yah, that's good. That test fails off and on for a bunch of us. Still haven't tracked it down. No worries.

Show
Jason van Zyl added a comment - Yah, that's good. That test fails off and on for a bunch of us. Still haven't tracked it down. No worries.
Hide
Permalink
Brian Fox added a comment - - edited

Discussed with Kenney via email: http://www.nabble.com/version-range-question-tf3250482s177.html and irc: http://irc.rectang.com/logs/codehaus/%23maven/20070315.html

The patch as written is currently not going to work. I will take this back and see. I think the most likely resolution is to work around inside my plugin, but I will probably add better comments to the javadoc in versionRange because it's confusing the way it is. Any fix has plenty of potential to break things. Ultimately this needs to be addressed in 2.1

Show
Brian Fox added a comment - - edited Discussed with Kenney via email: http://www.nabble.com/version-range-question-tf3250482s177.html and irc: http://irc.rectang.com/logs/codehaus/%23maven/20070315.html The patch as written is currently not going to work. I will take this back and see. I think the most likely resolution is to work around inside my plugin, but I will probably add better comments to the javadoc in versionRange because it's confusing the way it is. Any fix has plenty of potential to break things. Ultimately this needs to be addressed in 2.1
Hide
Permalink
Brian Fox added a comment -

Updated javadoc in 2.0.7...moving issue for better resolution in 2.1

Show
Brian Fox added a comment - Updated javadoc in 2.0.7...moving issue for better resolution in 2.1

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.