Add identity specification in maven-model and maven-settings

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Not A Bug
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: POM, Settings
  • Labels:
    None
  • Complexity:
    Intermediate

Description

Some generated objects are used in lists. Thus, it will be very useful to have identity specification for them: equals(..) and hashcode() (see MODELLO-43)
For instance, see org.apache.maven.model.Resource used in model/build/resources

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. MODELLO-83 Improvements for the generated methods equals(...), hashCode(), toString()

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-3265 maven-model Extension.equals causes NPE when any field is uninitialized

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-3266 maven-model RepositoryBase overrides equals() but not hashCode()

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Siveton added a comment -

Modello already generates these methods, just add the identifier parameter:

 
        <field>
          <name>name</name>
          <version>3.0.0+</version>
          <type>String</type>
          <identifier>true</identifier>
        </field>
Show
Vincent Siveton added a comment - Modello already generates these methods, just add the identifier parameter: 
 
        <field>
          <name>name</name>
          <version>3.0.0+</version>
          <type>String</type>
          <identifier>true</identifier>
        </field>
Hide
Permalink
Vincent Siveton added a comment -

Waiting for identities from the super class.

Show
Vincent Siveton added a comment - Waiting for identities from the super class.
Hide
Permalink
Jared Roberts added a comment -

Is there any way this could get patched back to the 2.0.x branch? These are defect fixes rather than new functionality and the project I'm working on would rather not wait until the 2.1 release.

Show
Jared Roberts added a comment - Is there any way this could get patched back to the 2.0.x branch? These are defect fixes rather than new functionality and the project I'm working on would rather not wait until the 2.1 release.
Hide
Permalink
John Casey added a comment -

Consolidating to 2.1.0-M1 so we can then rename to 2.1.0. We can weed out any issues we want to push to a later release from this set once we've done the consolidation.

Show
John Casey added a comment - Consolidating to 2.1.0-M1 so we can then rename to 2.1.0. We can weed out any issues we want to push to a later release from this set once we've done the consolidation.

People

  • Assignee:
    John Casey
    Reporter:
    Vincent Siveton
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: