Maven 2 & 3

ciManagement from parent is not merging with children

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.0.4
  • Fix Version/s: 3.2
  • Component/s: Inheritance and Interpolation
  • Labels:
    None
  • Environment:
    linux jdk1.5.0_10 amd64
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

If I define the following in my parent pom:

<ciManagement>
  <system>continuum</system>
  <url>http://blah</url>
</ciManagement>

and then in the child pom I have the following:

<ciManagement>
  <notifiers>
    <notifier>
      <type>mail</type>
      <configuration>
        <address>blah</address>
      </configuration>
    </notifier>
  </notifiers>
</ciManagement>

The ciManagement for the effective pom lacks the system and url properties from the parent pom. Seems like it should be merging them but isn't. This would helpful for reducing code duplication.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MNG-5052 ciManagement configuration ignore combine.children

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-3124 Inherit mailing lists from parent POM

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Bug - A problem which impairs or prevents the functions of the product. MNG-3845 [regression] Unintended inheritance of parent elements overriden by children

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Jason van Zyl made changes -
Field Original Value New Value
Fix Version/s Reviewed [ 13555 ]
Hide
Permalink
Paul Benedict added a comment - - edited

This would greatly help when submodules are ran by different developers. The software engineers can be placed in the parent POM, and additional developers notified via the children POM. In the company I work for, we aren't allowed to have custom mailing lists – so we have to list people (i.e., developers) individually in the POM. A pain, yes, but if this element was inheritable, it would be easier to deal with our constraint.

Show
Paul Benedict added a comment - - edited This would greatly help when submodules are ran by different developers. The software engineers can be placed in the parent POM, and additional developers notified via the children POM. In the company I work for, we aren't allowed to have custom mailing lists – so we have to list people (i.e., developers) individually in the POM. A pain, yes, but if this element was inheritable, it would be easier to deal with our constraint.
Paul Benedict made changes -
Link This issue depends upon MNG-3845 [ MNG-3845 ]
Benjamin Bentmann made changes -
Link This issue depends upon MNG-3845 [ MNG-3845 ]
Benjamin Bentmann made changes -
Link This issue relates to MNG-3845 [ MNG-3845 ]
Benjamin Bentmann made changes -
Description If I define the following in my parent pom:

<ciManagement>
  <system>continuum</system>
  <url>http://blah&lt;/url>
</ciManagement>

and then in the child pom I have the following:

<ciManagement>
  <notifier>
    <type>mail</type>
    <configuration>
      <address>blah</address>
    </configuration
  </notifier>
</ciManagement>

The ciManagement for the effective pom lacks the system and url properties from the parent pom. Seems like it should be merging them but isn't. This would helpful for reducing code duplication. 		If I define the following in my parent pom:
{code:xml}
<ciManagement>
  <system>continuum</system>
  <url>http://blah&lt;/url>
</ciManagement>
{code}
and then in the child pom I have the following:
{code:xml}
<ciManagement>
  <notifiers>
    <notifier>
      <type>mail</type>
      <configuration>
        <address>blah</address>
      </configuration>
    </notifier>
  </notifiers>
</ciManagement>
{code}
The ciManagement for the effective pom lacks the system and url properties from the parent pom. Seems like it should be merging them but isn't. This would helpful for reducing code duplication.
Hide
Permalink
Brett Porter added a comment -

this is currently by design - will need to review it in light of a model change

Show
Brett Porter added a comment - this is currently by design - will need to review it in light of a model change
Brett Porter made changes -
Fix Version/s Reviewed Pending Version Assignment [ 13555 ]
Fix Version/s 2.x [ 14504 ]
Hide
Permalink
Brett Porter added a comment -

need to review the role of these elements in a POM review. They might be better just being general "configuration" across a set of plugins

Show
Brett Porter added a comment - need to review the role of these elements in a POM review. They might be better just being general "configuration" across a set of plugins
Brett Porter made changes -
Fix Version/s 2.x [ 14504 ]
Fix Version/s 3.1 [ 15565 ]
Benjamin Bentmann made changes -
Link This issue is duplicated by MNG-5052 [ MNG-5052 ]
Herve Boutemy made changes -
Link This issue relates to MNG-3124 [ MNG-3124 ]
Hide
Permalink
Herve Boutemy added a comment -

MNG-3124 is exactly the same expectations and limits for mailing lists

Show
Herve Boutemy added a comment - MNG-3124 is exactly the same expectations and limits for mailing lists

People

  • Assignee:
    Unassigned
    Reporter:
    Kelly Davis
Vote (6)
Watch (4)

Dates

  • Created:
    Updated: