Maven 2 & 3

Repository entries are not validated and NPE will occur

Details

  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

Using something like the following has no id and an incorrect file url:

<profile>
<id>cbuilds</id>
<repositories>
<repository>
<url>/Users/jvanzyl/js/org/codehaus/mojo/trunk/mojo/mojo-sandbox/c-builds/test-cpkg/m2-repo</url>
</repository>
</repositories>
</profile>

java.lang.NullPointerException
at org.apache.maven.wagon.repository.Repository.hashCode(Repository.java:239)
at java.util.HashMap.hash(HashMap.java:264)
at java.util.HashMap.put(HashMap.java:382)
at java.util.HashSet.add(HashSet.java:194)
at org.apache.maven.project.DefaultMavenProjectBuilder.buildInternal(DefaultMavenProjectBuilder.java:665)
at org.apache.maven.project.DefaultMavenProjectBuilder.buildFromSourceFileInternal(DefaultMavenProjectBuilder.java:416)
at org.apache.maven.project.DefaultMavenProjectBuilder.build(DefaultMavenProjectBuilder.java:192)
at org.apache.maven.DefaultMaven.getProject(DefaultMaven.java:515)
at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:447)
at org.apache.maven.DefaultMaven.getProjects(DefaultMaven.java:351)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:278)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:256)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)

Issue Links

is duplicated by

Improvement - An improvement or enhancement to an existing feature or task. MNG-3857 Malformed respositories element could use a better error message

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Casey added a comment -

almost got the integration test done for this, but I'm snagged on some other (unrelated, I think) failing ITs. I'll continue to work on it, though.

Show
John Casey added a comment - almost got the integration test done for this, but I'm snagged on some other (unrelated, I think) failing ITs. I'll continue to work on it, though.
Hide
Permalink
John Casey added a comment -

added logic to ProjectUtils and MavenTools implementations to validate that repo ID and URL are present before constructing an ArtifactRepository instance.

Show
John Casey added a comment - added logic to ProjectUtils and MavenTools implementations to validate that repo ID and URL are present before constructing an ArtifactRepository instance.
Hide
Permalink
John Casey added a comment -

same thing is happening with mirror repositories, when id is left off. Need to guard against this somehow.

Show
John Casey added a comment - same thing is happening with mirror repositories, when id is left off. Need to guard against this somehow.
Hide
Permalink
Paul Benedict added a comment -

My first question is whether <id> and <url> are required elements? If so, why isn't the pull parser validating the syntax?

Show
Paul Benedict added a comment - My first question is whether <id> and <url> are required elements? If so, why isn't the pull parser validating the syntax?
Hide
Permalink
John Casey added a comment -

See MODELLO-44

Show
John Casey added a comment - See MODELLO-44
Hide
Permalink
John Casey added a comment -

fixed in 2.0.10 branch, will port/merge over to 2.0.x and trunk branches now.

Show
John Casey added a comment - fixed in 2.0.10 branch, will port/merge over to 2.0.x and trunk branches now.
Hide
Permalink
John Casey added a comment -

Adding fix-for for both 2.0.10 and 2.1.0-M1, since 2.1.0-M1 will actually be released first and may not incorporate all of the eventual issue fixes released in 2.0.10.

Show
John Casey added a comment - Adding fix-for for both 2.0.10 and 2.1.0-M1, since 2.1.0-M1 will actually be released first and may not incorporate all of the eventual issue fixes released in 2.0.10.
Hide
Permalink
Julien HENRY added a comment -

Hi,

It seems I have the same issue with one of my projects. It occurs during site creation (mvn clean install works fine).

>mvn site -X
+ Error stacktraces are turned on.
Apache Maven 2.1.0 (r755702; 2009-03-18 20:10:27+0100)
Java version: 1.6.0_12
Java home: C:\Program Files\Java\jdk1.6.0_12\jre
Default locale: fr_FR, platform encoding: Cp1252
OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
[DEBUG] Building Maven user-level plugin registry from: 'C:\Documents and Settings\jhenry\.m2\plugin-registry.xml'
[DEBUG] Building Maven global-level plugin registry from: 'D:\apache-maven-2.1.0\bin\..\conf\plugin-registry.xml'
[INFO] Scanning for projects...
[DEBUG] Searching for parent-POM: com.mycompany.sud:parent:pom:1.0.3-SNAPSHOT of project: mycompany.cust.project:project:jar:1.0-SNAPSHOT in relative path: ../pom.xml
[DEBUG] Parent-POM: com.mycompany.sud:parent:pom:1.0.3-SNAPSHOT not found in relative path: ../pom.xml
[DEBUG] Retrieving parent-POM: com.mycompany.sud:parent:pom:1.0.3-SNAPSHOT for project: mycompany.cust.project:project:jar:1.0-SNAPSHOT from the repository.
[DEBUG] Skipping disabled repository central
[DEBUG] parent: using locally installed snapshot
[DEBUG] Wagons could not be registered as the extension container was never created
[INFO] ------------------------------------------------------------------------
[INFO] Building project
[INFO]    task-segment: [site]
[INFO] ------------------------------------------------------------------------
[DEBUG] Retrieving parent-POM: org.apache.maven.plugins:maven-plugins:pom:11 for project: null:maven-site-plugin:maven-plugin:2.0-beta-7 from the repository.
[DEBUG] Retrieving parent-POM: org.apache.maven:maven-parent:pom:8 for project: org.apache.maven.plugins:maven-plugins:pom:11 from the repository.
[DEBUG] Retrieving parent-POM: org.apache:apache:pom:4 for project: org.apache.maven:maven-parent:pom:8 from the repository.
[DEBUG] Retrieving parent-POM: org.apache.maven.plugins:maven-plugins:pom:8 for project: null:maven-compiler-plugin:maven-plugin:2.0.2 from the repository.
[DEBUG] Retrieving parent-POM: org.apache.maven:maven-parent:pom:5 for project: org.apache.maven.plugins:maven-plugins:pom:8 from the repository.
[DEBUG] Retrieving parent-POM: org.apache:apache:pom:3 for project: org.apache.maven:maven-parent:pom:5 from the repository.
[DEBUG] Retrieving parent-POM: org.apache.maven.plugins:maven-plugins:pom:7 for project: org.apache.maven.plugins:maven-eclipse-plugin:maven-plugin:2.3 from the repository.
[DEBUG] Retrieving parent-POM: org.apache.maven:maven-plugin-surrogate-parent:pom:5 for project: org.apache.maven.plugin
s:maven-plugins:pom:7 from the repository.
[DEBUG] Retrieving parent-POM: org.apache.maven.surefire:surefire:pom:2.3 for project: org.apache.maven.plugins:maven-surefire-plugin:maven-plugin:2.3 from the repository.
[DEBUG] Retrieving parent-POM: org.apache.maven.plugins:maven-plugins:pom:4 for project: null:maven-javadoc-plugin:maven-plugin:2.2 from the repository.
[INFO] ------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] id can not be null
[INFO] ------------------------------------------------------------------------
[DEBUG] Trace
java.lang.NullPointerException: id can not be null
        at org.apache.maven.wagon.repository.Repository.<init>(Repository.java:81)
        at org.apache.maven.artifact.repository.DefaultArtifactRepository.<init>(DefaultArtifactRepository.java:70)
        at org.apache.maven.artifact.repository.DefaultArtifactRepositoryFactory.createDeploymentArtifactRepository(DefaultArtifactRepositoryFactory.java:44)
        at org.apache.maven.project.ProjectUtils.buildDeploymentArtifactRepository(ProjectUtils.java:80)
        at org.apache.maven.project.DefaultMavenProjectBuilder.processProjectLogic(DefaultMavenProjectBuilder.java:1038)

        at org.apache.maven.project.DefaultMavenProjectBuilder.buildInternal(DefaultMavenProjectBuilder.java:880)
        at org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:255)
        at org.apache.maven.plugin.DefaultPluginManager.checkRequiredMavenVersion(DefaultPluginManager.java:270)
        at org.apache.maven.plugin.DefaultPluginManager.verifyVersionedPlugin(DefaultPluginManager.java:198)
        at org.apache.maven.plugin.DefaultPluginManager.verifyReportPlugin(DefaultPluginManager.java:605)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.verifyReportPlugin(DefaultLifecycleExecutor.java:1557)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.getReportExecutions(DefaultLifecycleExecutor.java:912)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.getReportExecutions(DefaultLifecycleExecutor.java:888)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:583)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:540)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:519)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:371)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:332)
        at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:181)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:356)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:137)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:356)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
        at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
        at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
        at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1 second
[INFO] Finished at: Thu May 14 11:03:53 CEST 2009
[INFO] Final Memory: 5M/9M
[INFO] ------------------------------------------------------------------------
Show
Julien HENRY added a comment - Hi, It seems I have the same issue with one of my projects. It occurs during site creation (mvn clean install works fine). >mvn site -X + Error stacktraces are turned on. Apache Maven 2.1.0 (r755702; 2009-03-18 20:10:27+0100) Java version: 1.6.0_12 Java home: C:\Program Files\Java\jdk1.6.0_12\jre Default locale: fr_FR, platform encoding: Cp1252 OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows" [DEBUG] Building Maven user-level plugin registry from: 'C:\Documents and Settings\jhenry\.m2\plugin-registry.xml' [DEBUG] Building Maven global-level plugin registry from: 'D:\apache-maven-2.1.0\bin\..\conf\plugin-registry.xml' [INFO] Scanning for projects... [DEBUG] Searching for parent-POM: com.mycompany.sud:parent:pom:1.0.3-SNAPSHOT of project: mycompany.cust.project:project:jar:1.0-SNAPSHOT in relative path: ../pom.xml [DEBUG] Parent-POM: com.mycompany.sud:parent:pom:1.0.3-SNAPSHOT not found in relative path: ../pom.xml [DEBUG] Retrieving parent-POM: com.mycompany.sud:parent:pom:1.0.3-SNAPSHOT for project: mycompany.cust.project:project:jar:1.0-SNAPSHOT from the repository. [DEBUG] Skipping disabled repository central [DEBUG] parent: using locally installed snapshot [DEBUG] Wagons could not be registered as the extension container was never created [INFO] ------------------------------------------------------------------------ [INFO] Building project [INFO] task-segment: [site] [INFO] ------------------------------------------------------------------------ [DEBUG] Retrieving parent-POM: org.apache.maven.plugins:maven-plugins:pom:11 for project: null :maven-site-plugin:maven-plugin:2.0-beta-7 from the repository. [DEBUG] Retrieving parent-POM: org.apache.maven:maven-parent:pom:8 for project: org.apache.maven.plugins:maven-plugins:pom:11 from the repository. [DEBUG] Retrieving parent-POM: org.apache:apache:pom:4 for project: org.apache.maven:maven-parent:pom:8 from the repository. [DEBUG] Retrieving parent-POM: org.apache.maven.plugins:maven-plugins:pom:8 for project: null :maven-compiler-plugin:maven-plugin:2.0.2 from the repository. [DEBUG] Retrieving parent-POM: org.apache.maven:maven-parent:pom:5 for project: org.apache.maven.plugins:maven-plugins:pom:8 from the repository. [DEBUG] Retrieving parent-POM: org.apache:apache:pom:3 for project: org.apache.maven:maven-parent:pom:5 from the repository. [DEBUG] Retrieving parent-POM: org.apache.maven.plugins:maven-plugins:pom:7 for project: org.apache.maven.plugins:maven-eclipse-plugin:maven-plugin:2.3 from the repository. [DEBUG] Retrieving parent-POM: org.apache.maven:maven-plugin-surrogate-parent:pom:5 for project: org.apache.maven.plugin s:maven-plugins:pom:7 from the repository. [DEBUG] Retrieving parent-POM: org.apache.maven.surefire:surefire:pom:2.3 for project: org.apache.maven.plugins:maven-surefire-plugin:maven-plugin:2.3 from the repository. [DEBUG] Retrieving parent-POM: org.apache.maven.plugins:maven-plugins:pom:4 for project: null :maven-javadoc-plugin:maven-plugin:2.2 from the repository. [INFO] ------------------------------------------------------------------------ [ERROR] FATAL ERROR [INFO] ------------------------------------------------------------------------ [INFO] id can not be null [INFO] ------------------------------------------------------------------------ [DEBUG] Trace java.lang.NullPointerException: id can not be null at org.apache.maven.wagon.repository.Repository.<init>(Repository.java:81) at org.apache.maven.artifact.repository.DefaultArtifactRepository.<init>(DefaultArtifactRepository.java:70) at org.apache.maven.artifact.repository.DefaultArtifactRepositoryFactory.createDeploymentArtifactRepository(DefaultArtifactRepositoryFactory.java:44) at org.apache.maven.project.ProjectUtils.buildDeploymentArtifactRepository(ProjectUtils.java:80) at org.apache.maven.project.DefaultMavenProjectBuilder.processProjectLogic(DefaultMavenProjectBuilder.java:1038) at org.apache.maven.project.DefaultMavenProjectBuilder.buildInternal(DefaultMavenProjectBuilder.java:880) at org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:255) at org.apache.maven.plugin.DefaultPluginManager.checkRequiredMavenVersion(DefaultPluginManager.java:270) at org.apache.maven.plugin.DefaultPluginManager.verifyVersionedPlugin(DefaultPluginManager.java:198) at org.apache.maven.plugin.DefaultPluginManager.verifyReportPlugin(DefaultPluginManager.java:605) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.verifyReportPlugin(DefaultLifecycleExecutor.java:1557) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.getReportExecutions(DefaultLifecycleExecutor.java:912) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.getReportExecutions(DefaultLifecycleExecutor.java:888) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:583) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:540) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:519) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:371) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:332) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:181) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:356) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:137) at org.apache.maven.cli.MavenCli.main(MavenCli.java:356) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1 second [INFO] Finished at: Thu May 14 11:03:53 CEST 2009 [INFO] Final Memory: 5M/9M [INFO] ------------------------------------------------------------------------

People

  • Assignee:
    John Casey
    Reporter:
    Jason van Zyl
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: