Details
-
Type:
New Feature
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.1.0
-
Component/s: Command Line, Reactor and workspace
-
Labels:None
-
Complexity:Intermediate
-
Number of attachments :
Description
Add a commandline option to enable maven to expand the reactor scope to find projects that are dependencies
of the projects currently in the reactor, and add them.
Currently only the current project and child projects are included in the reactor search. I'm proposing
to add a commandline switch that lets maven check parent directories to find the root of the project tree,
and then do a normal reactor scan, only adding projects that would normally not be added if they're needed
as dependencies of the projects that would normally be built.
Here's a sample project tree:
- root
- p1
- c1 (depends on p2)
- p2 (depends on c2)
- p3
- c2
- p1
And a sample algorithm:
- When building c1, the reactor would contain [c1].
- Maven would check p1, then root, etc, using the <parent> tags (without the versions!)
to see if the project is still in the current reactor.
- It would then create a second list of projects (reactor2) containing ALL projects, using the newly discovered root: [root, p1, c2, p2].
- remove all projects from reactor2 contained in reactor: reactor2 = [root, p1, p2]
- resolve all direct dependencies for all projects in reactor in reactor2 and add them to reactor, taking versions into account: reactor = [p2, c1]
- repeat previous step until all projects have their dependencies resolved from reactor 2. first iteration would yield reactor = [c2, p2, c1],
next iteration would stop since c1 doesn't have any dependencies present in reactor2.
This would ensure that when some local project's sources have changed, they'll be incorporated
in the build, regardless of where you build. So you don't have to do a reactor build each time you change more
than 1 project, and you don't have to remember which projects you changed and build them in the correct order
yourself, manually.
Issue Links
| This issue is duplicated by: | ||||
| MNG-3377 | Build reactor from toplevel pom |
|
|
|
| MNG-4108 | Add ability to restart tests at a specific module instead of repeating successfully completed tests |
|
|
|
| MNG-2366 | child-level transitive dependency builds (http://www.mail-archive.com/users@maven.apache.org/msg32502.html) |
|
|
|
| This issue relates to: | ||||
| MNG-4324 | Add the ability to launch a reactor build with -amd or -am options from a submodule |
|
|
|
| MNG-4244 | Allow to select project for make-like reactor by artifact id |
|
|
|
| MNG-4260 | Remove old-school reactor mode |
|
|
|
| This issue is related to: | ||||
| MNG-1694 | Build execution order control in fine grained projects. |
|
|
|
Activity
It's not "-r" you want. -r is when you have a directory full of subdirectories, each of which is a project. I won't explain -r, because it makes very little sense. 
Instead, I'm going to compare the new feature to an old feature. This may confuse you, because it may make you accidentally use the old feature instead of the new feature.
Before this bug MNG-2576 was fixed, you had to use the Maven Reactor Plugin. http://maven.apache.org/plugins/maven-reactor-plugin/
Now, you can use --project-list, --also-make, --also-make-dependents, and --resume-from to get a similar effect.
Here's a table of old commands and their new Maven 2.1 commands.
1) "mvn reactor:resume -Dfrom=bar" is now "mvn --resume-from bar"
2) "mvn reactor:make -Dmake.folders=foo,bar" is now "mvn --project-list foo,bar --also-make"
3) "mvn reactor:make-dependents -Dmake.folders=foo,bar" is now "mvn --project-list foo,bar --also-make-dependents"
Make-like functionality is complicated; read the documentation for maven-reactor-plugin for more details.
Instead, I'm going to compare the new feature to an old feature. This may confuse you, because it may make you accidentally use the old feature instead of the new feature.
Before this bug Joerg,
A "," is not a "/".
"foo,bar" is for directory structures that look like this:
myroot | +-- foo +-- bar +-- quz
Normally "mvn install" from "myroot" would build all three subdirectories ("foo" "bar" "quz"). But "mvn -pl foo,quz" would build just foo and quz.
So you ask "what am I missing?" You're missing the "--also-make" directive.
If you want to build "foo" and everything "foo" depends on, you'd write: "mvn -pl foo -am". If you want to build foo and quz and everything they depend on, then you'd write "mvn -pl foo,quz -am". If bar were a subdirectory of foo, you could write "mvn -pl foo/bar -am".
I hope that helps. I'll try to put together a blog article about this in the hope that anyone could actually figure it out.
myroot | +-- foo +-- bar +-- quz
fixed algorithm description