mvn.bat file is not correct for 4NT 5.0 and does "endlocal" twice if error

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.4
  • Fix Version/s: 3.0-alpha-1
  • Component/s: Command Line
  • Labels:
    None
  • Environment:
    Windows XP SP2 and 4NT 5.00U
  • Complexity:
    Intermediate

Description

1. If not setup properly and error occurs, the script attempts to "endlocal" twice:

[d:] > mvn --version
Exception in thread "main" java.lang.NoClassDefFoundError: org/codehaus/classworlds/Launcher
4NT: D:\dev\maven2\bin\mvn.bat [145] Missing SETLOCAL

2. Syntax wrong for adding CLASSWORLDS_JAR when under 4NT.

For #1, I updated the :error section of the mvn.bat file.
For #2, I added a new section to add the CLASSWORLDS_JAR

  1. File
    mvn.bat
    15/Aug/06 2:37 PM
    5 kB
    Mark DeLaFranier

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-2685 mvn.bat detection of 4NT syntax error

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Siveton added a comment -

I tried to reproduce your problem with the last version of 4nt without success, ie
4NT 7.01 (4nt.exe, 3.2Mb, build 370) [1]

Try to upgrade your 4nt version. I'd like a confirmation before I close this issue.

Another tips for the next time, please refer to [2], "Creating and submitting a patch" part
Thanks!

[1] http://jpsoft.com/download.htm
[2] http://maven.apache.org/guides/development/guide-m2-development.html

Show
Vincent Siveton added a comment - I tried to reproduce your problem with the last version of 4nt without success, ie 4NT 7.01 (4nt.exe, 3.2Mb, build 370) [1] Try to upgrade your 4nt version. I'd like a confirmation before I close this issue. Another tips for the next time, please refer to [2], "Creating and submitting a patch" part Thanks! [1] http://jpsoft.com/download.htm [2] http://maven.apache.org/guides/development/guide-m2-development.html
Hide
Permalink
Mark DeLaFranier added a comment -

Vincent,

I am not in a position to test with version 7.01 as I don't have access to this software - at least not in the short term.

Thanks for the tip for the next time.

Mark

Show
Mark DeLaFranier added a comment - Vincent, I am not in a position to test with version 7.01 as I don't have access to this software - at least not in the short term. Thanks for the tip for the next time. Mark
Hide
Permalink
Andrew Forman added a comment -

I can confirm issue #1.
I've 4NT 8.00.36 and do see the SETLOCAL error when running the mvn.bat that comes with 2.0.4.

The fix I made to resolve the issue was to change the :error section, removing the @endlocal (as follows).

:error
if "%OS%"=="Windows_NT"
set ERROR_CODE=1

Show
Andrew Forman added a comment - I can confirm issue #1. I've 4NT 8.00.36 and do see the SETLOCAL error when running the mvn.bat that comes with 2.0.4. The fix I made to resolve the issue was to change the :error section, removing the @endlocal (as follows). :error if "%OS%"=="Windows_NT" set ERROR_CODE=1
Hide
Permalink
John Casey added a comment -

Applied a patch generated from the attached mvn.bat file, with some minor modifications. This has been applied against trunk...can someone verify that it works? I will merge it to the branch, but I don't have windows...

Show
John Casey added a comment - Applied a patch generated from the attached mvn.bat file, with some minor modifications. This has been applied against trunk...can someone verify that it works? I will merge it to the branch, but I don't have windows...

People

  • Assignee:
    John Casey
    Reporter:
    Mark DeLaFranier
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: