jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven 2 & 3
  • MNG-249

compile and package should be reactor-aware

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-beta-1
  • Component/s: Plugins and Lifecycle
  • Labels:
    None
  • Environment:
    any

Description

When compiling or packaging a project consisting of subprojects
where one depends on another, maven should first check the build environment
for existing jars or classes (in target/ directories) from the dependent subproject,
rather than always looking in the local and remote repositories for jar artifacts.

Attached is a very simple test-case with 2 subprojects, where one depends
on the other.

Only m2 install works; m2 compile and m2 package should also work.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. File
    m2test.tgz
    05/Apr/05 11:11 AM
    0.5 kB
    Kenney Westerhof

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-2921 ejb-client dependency no longer resolved in reactor build

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-1088 Plugins built and used within the same multiproject build fail unless lifecycle phase is compile or later

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-3043 Allow 'mvn test' to work with test-jar dependencies in a reactor

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

New Feature - A new feature of the product, which has yet to be developed. MNG-870 Make plugin discovery reactor aware

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Brett Porter added a comment - 05/Apr/05 11:31 AM

I think this is possible, and a good idea.

the compile phase does not require the resources of the other projects - just their classes. So when getting the classpath elements in maven-core, anything inside the reactor for compile can be passed back as target/classes directories, etc.

My only problem with this is if too much hardwiring of phase <-> code occurs in maven-core. That would need some investigation, but in theory this is a good idea.

It will also be a little faster, and makes the compile step somewhat more atomic (if compile fails, nothing is installed, for example)

Show
Brett Porter added a comment - 05/Apr/05 11:31 AM I think this is possible, and a good idea. the compile phase does not require the resources of the other projects - just their classes. So when getting the classpath elements in maven-core, anything inside the reactor for compile can be passed back as target/classes directories, etc. My only problem with this is if too much hardwiring of phase <-> code occurs in maven-core. That would need some investigation, but in theory this is a good idea. It will also be a little faster, and makes the compile step somewhat more atomic (if compile fails, nothing is installed, for example)
Hide
Permalink
Brett Porter added a comment - 28/Jul/05 4:32 AM

done, but there is a bit of dodgniess I will try and clean up before closing

Show
Brett Porter added a comment - 28/Jul/05 4:32 AM done, but there is a bit of dodgniess I will try and clean up before closing

People

  • Assignee:
    Brett Porter
    Reporter:
    Kenney Westerhof
Vote (0)
Watch (0)

Dates

  • Created:
    05/Apr/05 11:11 AM
    Updated:
    07/Aug/10 12:48 PM
    Resolved:
    28/Jul/05 9:18 AM

Time Tracking

Estimated:
4h
Original Estimate - 4 hours
Remaining:
0m
Remaining Estimate - 0 minutes
Logged:
4h
Time Spent - 4 hours
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.