Maven
  1. Maven
  2. MNG-2471

Add search box to the index page

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Documentation: General
    • Labels:
      None
    • Complexity:
      Intermediate
    • Patch Submitted:
      Yes
    • Number of attachments :
      12

      Description

      • google for now
      1. index.html
        11 kB
        Marvin King
      2. index[wlogo_wfocus_XHTML_CSS].html
        11 kB
        Denis Cabasson
      3. index[wlogo_wfocus_XHTML_CSS2].html
        11 kB
        Denis Cabasson
      4. index[wlogo_wfocus_XHTML].html
        11 kB
        Denis Cabasson
      5. index-wfocus-woutlogo-wmojocodehausoption.html
        11 kB
        Marvin King
      6. index-with-focus.html
        11 kB
        Dennis Lundberg
      7. index-without-logo-with-mojocodehausoption.html
        11 kB
        Marvin King
      8. MNG-2471-site.patch
        1 kB
        Marvin King
      9. MNG-2471-site[with_focus_smallsearchbox_withmojocodehausoption].patch
        5 kB
        Marvin King
      10. MNG-2471-site[wlogo_wfocus_XHTML].patch
        5 kB
        Denis Cabasson
      11. site[wlogo_wfocus_XHTML].css
        0.7 kB
        Denis Cabasson
      12. site-without-logo-with-mojocodehausoption.css
        0.6 kB
        Marvin King

        Issue Links

          Activity

          Hide
          Marvin King added a comment -
          • initial draft
          Show
          Marvin King added a comment - initial draft
          Hide
          Marvin King added a comment -


          the search box will only search within the maven site.

          Show
          Marvin King added a comment - the search box will only search within the maven site.
          Hide
          Denis Cabasson added a comment -

          Now, that is a big box!!!

          Isn't there a way to make the Google logo a bit smaller? (I guess there are legals considerations there).

          For the design part, I would prefer 2 separate boxes for search and download.

          Would it be possible to add a radio button to include search in the mojo.codehaus.org domain (in addition to maven.apache.org) (maybe legal considerations there too)?

          Show
          Denis Cabasson added a comment - Now, that is a big box!!! Isn't there a way to make the Google logo a bit smaller? (I guess there are legals considerations there). For the design part, I would prefer 2 separate boxes for search and download. Would it be possible to add a radio button to include search in the mojo.codehaus.org domain (in addition to maven.apache.org) (maybe legal considerations there too)?
          Hide
          Marvin King added a comment -
          • applied dennis's suggestion
          Show
          Marvin King added a comment - applied dennis's suggestion
          Hide
          Dennis Lundberg added a comment -

          Using the original proposal, I added a small javascript that sets focus to the searchbox so that you can start typing right away.

          I also moved the image outside of the form and removed a paragraph to minimize the space above the image.

          Show
          Dennis Lundberg added a comment - Using the original proposal, I added a small javascript that sets focus to the searchbox so that you can start typing right away. I also moved the image outside of the form and removed a paragraph to minimize the space above the image.
          Hide
          Brett Porter added a comment -

          I like the separate box with no image better - can we get that one as a patch with the focus javascript?

          Show
          Brett Porter added a comment - I like the separate box with no image better - can we get that one as a patch with the focus javascript?
          Hide
          Marvin King added a comment -


          done

          Show
          Marvin King added a comment - done
          Hide
          Denis Cabasson added a comment -

          After a bit of research, it seems we have to keep Google's logo:
          http://www.google.com/searchcode.html

          So I guess we can still go for the smaller logo:
          http://www.google.com/logos/Logo_25wht.gif

          I guess the last version, with google Logo aboce the search box would be fine for me (but now, I'm just a user, so my view is not that important )

          Show
          Denis Cabasson added a comment - After a bit of research, it seems we have to keep Google's logo: http://www.google.com/searchcode.html So I guess we can still go for the smaller logo: http://www.google.com/logos/Logo_25wht.gif I guess the last version, with google Logo aboce the search box would be fine for me (but now, I'm just a user, so my view is not that important )
          Hide
          Denis Cabasson added a comment -

          Submitted my recommended changes:

          • Include smallest Google logo, for legal reasons
          • Strip br in the box, as they don't have any use
          • Change id of new box, and make use of classes instead
          • Try to comply with XHTML standard. Only 3 issues remaining on this point, but they are already there in current version.

          + Make use of existing focus script (with improvement to Javascript code).

          Show
          Denis Cabasson added a comment - Submitted my recommended changes: Include smallest Google logo, for legal reasons Strip br in the box, as they don't have any use Change id of new box, and make use of classes instead Try to comply with XHTML standard. Only 3 issues remaining on this point, but they are already there in current version. + Make use of existing focus script (with improvement to Javascript code).
          Hide
          Denis Cabasson added a comment -

          corrected CSS stylesheet

          Show
          Denis Cabasson added a comment - corrected CSS stylesheet
          Hide
          Denis Cabasson added a comment -

          Corrected link to css (so that HTML page can be viewed)

          Show
          Denis Cabasson added a comment - Corrected link to css (so that HTML page can be viewed)
          Hide
          Denis Cabasson added a comment -

          I'm getting crazy.... Hope this time uploaded html will be right.

          I guess this entry need a little clean-up (but I haven't got the necessary credentials).

          Show
          Denis Cabasson added a comment - I'm getting crazy.... Hope this time uploaded html will be right. I guess this entry need a little clean-up (but I haven't got the necessary credentials).
          Hide
          Jason van Zyl added a comment -

          The search box is way to huge and this really needs to be integrated as an option in the site plugin.

          Show
          Jason van Zyl added a comment - The search box is way to huge and this really needs to be integrated as an option in the site plugin.
          Hide
          Jason van Zyl added a comment -

          Someone can reopen this is they care. It's all Maven committers anyway now working on this.

          Show
          Jason van Zyl added a comment - Someone can reopen this is they care. It's all Maven committers anyway now working on this.
          Hide
          Denis Cabasson added a comment -

          Thanks for your comment Jason, but I'm not to any extend a maven comitter (only a modello one, and I ain't doing anything on modello right now).

          Anyway, why was this abandonned? Can you tell me a bit more about what you would like to be done about it?

          Thanks!

          Show
          Denis Cabasson added a comment - Thanks for your comment Jason, but I'm not to any extend a maven comitter (only a modello one, and I ain't doing anything on modello right now). Anyway, why was this abandonned? Can you tell me a bit more about what you would like to be done about it? Thanks!

            People

            • Assignee:
              Unassigned
              Reporter:
              Marvin King
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: