Add @since javadoc tags to plugin parameters

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.4
  • Fix Version/s: 3.0-alpha-1
  • Component/s: Documentation: General
  • Labels:
    None
  • Complexity:
    Intermediate

Description

also, update the plugin report and add a separate column for this tag

  1. Text File
    MNG-2406-maven-plugin-descriptor.patch
    26/Jun/06 2:11 AM
    0.8 kB
    Edwin Punzalan
  2. Text File
    MNG-2406-maven-plugin-tools-api.patch
    26/Jun/06 2:11 AM
    1 kB
    Edwin Punzalan
  3. Text File
    MNG-2406-maven-plugin-tools-java.patch
    28/Jun/06 8:31 PM
    4 kB
    Edwin Punzalan
  4. Text File
    MNG-2406-maven-plugin-tools-java.patch
    26/Jun/06 2:11 AM
    4 kB
    Edwin Punzalan

Issue Links

is related to

New Feature - A new feature of the product, which has yet to be developed. MNG-2454 add @since to mojo at class level

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Edwin Punzalan added a comment -

I've attached the patches to fix this issue.

Show
Edwin Punzalan added a comment - I've attached the patches to fix this issue.
Hide
Permalink
Brett Porter added a comment -

this appears to use @parameter since="..." instead of just @since ...

Can you confirm?

Show
Brett Porter added a comment - this appears to use @parameter since="..." instead of just @since ... Can you confirm?
Hide
Permalink
Edwin Punzalan added a comment -

Brett, you're right. The replacement patch makes it @since instead.

Show
Edwin Punzalan added a comment - Brett, you're right. The replacement patch makes it @since instead.
Hide
Permalink
Dennis Lundberg added a comment -

I have a couple of questions about this issue:

1. Shouldn't "since" be added to the plugin metadata model as well? I'm not sure what the model is used for, but it seems to include most of the other things.

2. Is there a special reason for not putting this in the 2.0.x branch? Just because it's a new feature?

The reason I'm asking is because I wanted to try to fix MNG-2454, and I want to do it the correct way.

Show
Dennis Lundberg added a comment - I have a couple of questions about this issue: 1. Shouldn't "since" be added to the plugin metadata model as well? I'm not sure what the model is used for, but it seems to include most of the other things. 2. Is there a special reason for not putting this in the 2.0.x branch? Just because it's a new feature? The reason I'm asking is because I wanted to try to fix MNG-2454, and I want to do it the correct way.
Hide
Permalink
Edwin Punzalan added a comment -

Dennis,

1. I agree. It should also appear there for the scripting-based plugins to use it.

Show
Edwin Punzalan added a comment - Dennis, 1. I agree. It should also appear there for the scripting-based plugins to use it.

People

  • Assignee:
    Edwin Punzalan
    Reporter:
    Edwin Punzalan
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
4h
Original Estimate - 4 hours
Remaining:
0m
Remaining Estimate - 0 minutes
Logged:
1h 30m
Time Spent - 1 hour, 30 minutes Time Not Required