Issue Details (XML | Word | Printable)

Key: MNG-2387
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Brett Porter
Reporter: Brett Porter
Votes: 3
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Maven 2 & 3

<active> on <proxy> in settings is misleading

Created: 17/Jun/06 03:52 AM   Updated: 28/Mar/09 02:03 PM   Resolved: 25/Feb/09 01:07 AM
Component/s: Settings
Affects Version/s: None
Fix Version/s: 2.0.11, 2.1.0, 3.0-alpha-3

Time Tracking:
Not Specified

File Attachments: 1. Text File MNG-2387-maven-settings.patch (5 kB)


Complexity: Intermediate
Patch Submitted: Yes



Lars Vonk added a comment - 28/Aug/08 02:59 AM

Hi, will this be fixed? The above link does not include the complete Thread by the way. Here is the correct link:

http://mail-archives.apache.org/mod_mbox/maven-users/200510.mbox/%3C9e3862d80510171832u1e4204ds81b7c9ae3e5b9da7@mail.gmail.com%3E

Problem is that the proxy actually gets set as system property regardless of the active flag. this also causes problems for other libraries that look at this property when you for instance run svnkit inside an application in the jetty-maven-plugin. See: http://jira.codehaus.org/browse/JETTY-694


Torben S. Giesselmann added a comment - 26/Jan/09 02:38 PM

This patch produces the intended behavior:

  • empty proxy section --> no active proxy
  • only inactive proxies --> no active proxy
  • at least one active proxy --> first active proxy is returned

Test cases included.


Brett Porter added a comment - 25/Feb/09 12:53 AM

I added an integration test as well. It'd be great if you could also submit those in future

Thanks for the patch!


Torben S. Giesselmann added a comment - 25/Feb/09 01:12 PM

Yup, I'll do that next time.

Actually I just submitted my very first IT (see MNG-3641): kudos to Benjamin for teaching me the "tricks of the trade"! So ... no more excuses for me!


Benjamin Bentmann added a comment - 28/Mar/09 02:03 PM

Merged to 3.x in r759552.