Maven 2 & 3

<active> on <proxy> in settings is misleading

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0.11, 2.1.0, 3.0-alpha-3
  • Component/s: Settings
  • Labels:
    None
  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Lars Vonk added a comment -

Hi, will this be fixed? The above link does not include the complete Thread by the way. Here is the correct link:

http://mail-archives.apache.org/mod_mbox/maven-users/200510.mbox/%3C9e3862d80510171832u1e4204ds81b7c9ae3e5b9da7@mail.gmail.com%3E

Problem is that the proxy actually gets set as system property regardless of the active flag. this also causes problems for other libraries that look at this property when you for instance run svnkit inside an application in the jetty-maven-plugin. See: http://jira.codehaus.org/browse/JETTY-694

Show
Lars Vonk added a comment - Hi, will this be fixed? The above link does not include the complete Thread by the way. Here is the correct link: http://mail-archives.apache.org/mod_mbox/maven-users/200510.mbox/%3C9e3862d80510171832u1e4204ds81b7c9ae3e5b9da7@mail.gmail.com%3E Problem is that the proxy actually gets set as system property regardless of the active flag. this also causes problems for other libraries that look at this property when you for instance run svnkit inside an application in the jetty-maven-plugin. See: http://jira.codehaus.org/browse/JETTY-694
Hide
Permalink
Torben S. Giesselmann added a comment -

This patch produces the intended behavior:

  • empty proxy section --> no active proxy
  • only inactive proxies --> no active proxy
  • at least one active proxy --> first active proxy is returned

Test cases included.

Show
Torben S. Giesselmann added a comment - This patch produces the intended behavior:
  • empty proxy section --> no active proxy
  • only inactive proxies --> no active proxy
  • at least one active proxy --> first active proxy is returned
Test cases included.
Hide
Permalink
Brett Porter added a comment -

I added an integration test as well. It'd be great if you could also submit those in future

Thanks for the patch!

Show
Brett Porter added a comment - I added an integration test as well. It'd be great if you could also submit those in future Thanks for the patch!
Hide
Permalink
Torben S. Giesselmann added a comment -

Yup, I'll do that next time.

Actually I just submitted my very first IT (see MNG-3641): kudos to Benjamin for teaching me the "tricks of the trade"! So ... no more excuses for me!

Show
Torben S. Giesselmann added a comment - Yup, I'll do that next time. Actually I just submitted my very first IT (see MNG-3641): kudos to Benjamin for teaching me the "tricks of the trade"! So ... no more excuses for me!
Hide
Permalink
Benjamin Bentmann added a comment -

Merged to 3.x in r759552.

Show
Benjamin Bentmann added a comment - Merged to 3.x in r759552.

People

Vote (3)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.