Maven 2 & 3

classes before test-classes in MavenProject.getTestClasspathElements() - should be the other way around?

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: 2.0.4
  • Fix Version/s: None
  • Component/s: Reactor and workspace
  • Labels:
    None
  • Environment:
    doesnt matter
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

in getTestClasspathElements() we have:

List list = new ArrayList( getArtifacts().size() + 1 );
list.add( getBuild().getOutputDirectory() );
list.add( getBuild().getTestOutputDirectory() );

  • causing classes to be prior to test-classes in the classpath- something then prohibits test-resources/classes to shadow classes/ resources fom main. .I.e. it is not possible to redefine resources/classes for usage when running tests.

Sugested solution:
List list = new ArrayList( getArtifacts().size() + 1 );
list.add( getBuild().getTestOutputDirectory() );
list.add( getBuild().getOutputDirectory() );

add test-classes before classes

Issue Links

duplicates

Improvement - An improvement or enhancement to an existing feature or task. MNG-3118 Test-classes should come before classes in the classpath

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
John Casey made changes -
Field Original Value New Value
Fix Version/s 2.0.5 [ 12294 ]
Hide
Permalink
Brett Porter added a comment -

while this makes sense to me, ISTR having to change this in the past. Please investigate SVN history before doing this.

Show
Brett Porter added a comment - while this makes sense to me, ISTR having to change this in the past. Please investigate SVN history before doing this.
Kenney Westerhof made changes -
Fix Version/s 2.0.6 [ 13010 ]
Fix Version/s 2.0.5 [ 12294 ]
Jason van Zyl made changes -
Fix Version/s 2.0.6 [ 13010 ]
Fix Version/s 2.0.x [ 13141 ]
Brett Porter made changes -
Component/s Reactor and workspace [ 11938 ]
Benjamin Bentmann made changes -
Link This issue duplicates MNG-3118 [ MNG-3118 ]
Hide
Permalink
Benjamin Bentmann added a comment -

This patch includes a unit test to to check the proper test class path ordering.

Show
Benjamin Bentmann added a comment - This patch includes a unit test to to check the proper test class path ordering.
Benjamin Bentmann made changes -
Attachment MNG-3118-test.patch [ 30662 ]
Hide
Permalink
John Casey added a comment -

applied the unit test, and all tests out just fine.

Show
John Casey added a comment - applied the unit test, and all tests out just fine.
John Casey made changes -
Fix Version/s 2.2.0 [ 15103 ]
Status Open [ 1 ] Closed [ 6 ]
Resolution Cannot Reproduce [ 5 ]
Assignee John Casey [ jdcasey ]
Fix Version/s 2.2.x [ 13141 ]
Benjamin Bentmann made changes -
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Cannot Reproduce [ 5 ]
Benjamin Bentmann made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Fix Version/s 2.2.0 [ 15103 ]
Resolution Duplicate [ 3 ]

People

  • Assignee:
    John Casey
    Reporter:
    kai lilleby
Vote (12)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved: