Maven 2 & 3

Profile activation order is random

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
  • Fix Version/s: 2.0.5
  • Component/s: Reactor and workspace
  • Labels:
    None
  • Environment:
    all
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

The order in which profiles are activated is currently random.

Say you have two profiles:

<profile>
  <id>default</id>
  <properties>
    <test>DEFAULT</test>
  </properties>
</profile>

<profile>
  <id>override</id>
  <properties>
    <test>OVERRIDE</test>
  </properties>
</profile>

and you run 

mvn projecthelp:effective-pom -Pdefault,override

on any pom, then then <properties> section at the bottom will
probably show 

<test>DEFAULT</test>

.

The same happens if you specify '<activeProfiles><activeProfile>default</..></..>' and run with 'mvn -Poverride'.

This breaks overriding settings since the merge order is random because DefaultProfileManager uses
a HashMap to add active profiles, and HashMap iterators are random.

Proposed fix is to use a LinkedHashMap.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MNG-4106 [regression] Interpolation does not use properties from dominant settings profile if other profile defines same property

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-4107 [regression] User settings can't override properties used for POM interpolation

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-4741 Priority for profiles activated by property or -P unclear

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. MNG-4946 Let the order of profiles in `mvn -P...` determine their order in effective POM

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Hide
Permalink
Kenney Westerhof added a comment -

Fixed in trunk revision 408021.

Merged in 2.0.x branch in revision 408023.

Show
Kenney Westerhof added a comment - Fixed in trunk revision 408021. Merged in 2.0.x branch in revision 408023.

People

  • Assignee:
    Kenney Westerhof
    Reporter:
    Kenney Westerhof
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: