<dependencyManagement><dependency><version>'s are not used when evaluating <plugin><dependencies><dependency>

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Inheritance and Interpolation
  • Labels:
    None
  • Environment:
    2.0.2-SNAPSHOT
  • Complexity:
    Intermediate

Description

dep management is not honoured for plugins dep evaluation.

<kenney> hm.. looks like inheritance, after investigating.. the MavenMetaDataSource doesn't use the MavenProject.getDependencyManagement
<kenney> jah.. found it.
<jallen> NICE, estimate... 30 mins or 30 hrs?
<kenney> 30 mins
<kenney> the maven-project DefaultMavenProjectBuilder uses a different method in the ArtifactResolved to resolve deps than the maven-core DefaultPluginManager
<kenney> but all the info is available..

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-2496 dependencyManagement not used for dependencies in plugin section.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kenney Westerhof added a comment -

Related sources:

maven-project/.../DefaultMavenProjectBuilder.java, line 320: call to createManagedVersionMap.
Proposal: move to MavenProject.

Line 340: call to ArtifactResolver.resolveTransitively( ..., ..., managedVersionMap, ...);

maven-core/.../DefaultPluginManager.java, line 608. Call to ArtifactResolver.resolveTransitively(.., ..., ...)
(without the managedVersionMap).

Proposal: add call to moved createManagedVersionMap function as a parameter.

Show
Kenney Westerhof added a comment - Related sources: maven-project/.../DefaultMavenProjectBuilder.java, line 320: call to createManagedVersionMap. Proposal: move to MavenProject. Line 340: call to ArtifactResolver.resolveTransitively( ..., ..., managedVersionMap, ...); maven-core/.../DefaultPluginManager.java, line 608. Call to ArtifactResolver.resolveTransitively(.., ..., ...) (without the managedVersionMap). Proposal: add call to moved createManagedVersionMap function as a parameter.
Hide
Permalink
John Allen added a comment -

Been an age can this be looked at for 2.1?

Show
John Allen added a comment - Been an age can this be looked at for 2.1?
Hide
Permalink
Jason van Zyl added a comment -

The dependencyManagement element is not for managing plugins or extension.

Show
Jason van Zyl added a comment - The dependencyManagement element is not for managing plugins or extension.
Hide
Permalink
Barrie Treloar added a comment -

Jason is saying that plugin dependencies must be partitioned from the artifacts dependencies.

See http://jira.codehaus.org/browse/MNG-2496#action_98367 for a more detailed explanation.

Show
Barrie Treloar added a comment - Jason is saying that plugin dependencies must be partitioned from the artifacts dependencies. See http://jira.codehaus.org/browse/MNG-2496#action_98367 for a more detailed explanation.
Hide
Permalink
John Allen added a comment -

A dependency is a dependency. Dependency management is for aligning those dependencies. I think the distinction is moot but i look forward to a new way of aligning plugin dependencies that is better than relying upon ${properties}.

Show
John Allen added a comment - A dependency is a dependency. Dependency management is for aligning those dependencies. I think the distinction is moot but i look forward to a new way of aligning plugin dependencies that is better than relying upon ${properties}.
Hide
Permalink
John Allen added a comment -

Although i do see the point. IMHO the problem lies in the fact I can not use specifications within the POM to help manage the build setup itself (ie a 'build' scope).

Show
John Allen added a comment - Although i do see the point. IMHO the problem lies in the fact I can not use specifications within the POM to help manage the build setup itself (ie a 'build' scope).
Hide
Permalink
Jörg Hohwiller added a comment -

I also disagree with "Won't fix"

> The dependencyManagement element is not for managing plugins or extension.
This is not the point here.

If e.g. maven-antrun-plugin is used and one adds a dependency to ant and ant-contrib that is just a plain dependency and no plugin. This should be treated as any other dependency. And as shown by the two redundant issues on this topic it seems to be just natural to expect maven to behave like this. Without a fix on this one has to add redundant exclusions, etc. to his POMs.
Maven is really great in reducing redundancies with all the POM inheritance features and convention-over-configuration philosophy, etc.
I can not see a reason why this feature should not be added.

Show
Jörg Hohwiller added a comment - I also disagree with "Won't fix" > The dependencyManagement element is not for managing plugins or extension. This is not the point here. If e.g. maven-antrun-plugin is used and one adds a dependency to ant and ant-contrib that is just a plain dependency and no plugin. This should be treated as any other dependency. And as shown by the two redundant issues on this topic it seems to be just natural to expect maven to behave like this. Without a fix on this one has to add redundant exclusions, etc. to his POMs. Maven is really great in reducing redundancies with all the POM inheritance features and convention-over-configuration philosophy, etc. I can not see a reason why this feature should not be added.
Hide
Permalink
Joerg Schaible added a comment -

You silently imply that dependency management is only applied for the explicitly declared dependencies of a plugin. Applying it for all dependencies of a plugin would be desastrous and make very brittle builds, because an upgrade of a dependency of my project could break a plugin used in teh lifecycle.

Show
Joerg Schaible added a comment - You silently imply that dependency management is only applied for the explicitly declared dependencies of a plugin. Applying it for all dependencies of a plugin would be desastrous and make very brittle builds, because an upgrade of a dependency of my project could break a plugin used in teh lifecycle.

People

  • Assignee:
    Jason van Zyl
    Reporter:
    John Allen
Vote (6)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved: