[#MNG-2066] Specify multiple proxies - jira.codehaus.org

Maven 2 & 3

Specify multiple proxies

Created: 12/Feb/06 09:03 AM Updated: 12/Jun/08 05:51 PM Resolved: 02/Jun/07 05:11 PM

Component/s:

None

Affects Version/s:

2.0.2

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

MNG-2066-maven-site.patch (1 kB)
2.

MNG-2066-maven.patch (17 kB)
3.

multiple-proxies-paches.zip (2 kB)

Issue Links:

dependent

This issue is depended upon by:

~~WAGON-125~~ The https protocol is implemented by the LightweightHttpWagon component which does not support https proxy

Complexity:	Intermediate
Patch Submitted:	Yes

Description

« Hide

After this discussion :
http://www.mail-archive.com/dev@maven.apache.org/msg53099.html

In the attached zip file, you'll find four patch files :

on the maven-artifact-manager projet : changes in the DefaultWagonManager class, using the http proxy when no https proxy is specified.
on the maven-core project : changes in the DefaultMaven, adding all teh active proxies from the settings to the wagon manager
on the maven-settings project : changes in the settings.mdo file

Theses patches are built on the maven-2.0.x branch.

Sort Order:

[ Permalink | « Hide ]

Carlos Sanchez added a comment - 27/Nov/06 01:27 PM

Some comments:

patches have to be against trunk
public api can't be modified, we need to keep backwards compatibility
need documentation, for instance that setting http proxy will affect https requests
unit tests would be great

[ Permalink | « Hide ]

Thomas Recloux added a comment - 27/Nov/06 03:39 PM

Thanks for your comments

> patches have to be against trunk

Does this mean this patch can't be integrated until 2.1 ?

> public api can't be modified, we need to keep backwards compatibility

You are speaking of the Settings object ? In this case, can I had a "java.util.List getActiveProxies()" method and keep the "Proxy getActiveProxy()" ? Should I mark it has deprecated ?

> need documentation, for instance that setting http proxy will affect https requests

Where should I document it ? In this guide : http://maven.apache.org/guides/mini/guide-proxies.html ?

> unit tests would be great

[ Permalink | « Hide ]

Carlos Sanchez added a comment - 27/Nov/06 03:54 PM

> Does this mean this patch can't be integrated until 2.1 ?

No, just that we work against trunk and then merge to the 2.0.x branch if needed

> You are speaking of the Settings object ? In this case, can I had a "java.util.List getActiveProxies()" method and keep the "Proxy getActiveProxy()" ? Should I mark it has deprecated ?

Yes

> Where should I document it ? In this guide : http://maven.apache.org/guides/mini/guide-proxies.html ?

Yes, and also javadocs would be great

[ Permalink | « Hide ]

Thomas Recloux added a comment - 03/Dec/06 04:54 AM

Patch for maven components trunk

[ Permalink | « Hide ]

Thomas Recloux added a comment - 03/Dec/06 04:55 AM

Patch for maven site trunk

[ Permalink | « Hide ]

Jason van Zyl added a comment - 02/Jun/07 05:11 PM

This is too complicated for Maven. If you have more then one repository that you need to use then you can use one of the many proxying tools. Trying to cycle through proxies doesn't seem all that great. And really you want to be able to bind a proxy to a particular repository as you know what you are trying to get and where. This is not the right solution. Nothing more then simple proxy support belongs in Maven as the proxying solutions are available now and work. See Proximity.