Maven
  1. Maven
  2. MNG-2010

Add new lifecycle phases for IT

    Details

    • Complexity:
      Intermediate
    • Patch Submitted:
      Yes
    • Number of attachments :
      2

      Description

      Namely:

      • generate-integration-test-sources
      • process-integration-test-sources
      • generate-integration-test-resources
      • process-integration-test-resources
      • integration-test-compile

      and possibly a:

      • integration-test-package

        Issue Links

          Activity

          Hide
          Kenney Westerhof added a comment -

          I have to agree with jason and john - keep the lifecycle small.

          About a year ago I started the maven-it-plugin, with the idea of using any standard lifecycle as a 'forked' sub-lifecycle.
          the 'integration-test' phase would run maven (embedded) on src/it/*/pom.xml, where each project could run any lifecycle
          they wish - by specifying a packaging. Normally you'd just have some tests in src/test/ which get executed.

          This way you can run multiple integration tests, without separate modules (unless you see src/it/* as modules).
          I think this, or something similar, is the way to go. We cannot simply grow the main lifecycle any time another usecase comes up.
          it's already too big - there should be just one integration-test phase; i don't even see the need for the pre- and post- phases there.
          It should be a hook to run a new lifecycle, like a subroutine. That should be flexible enough for anybody.

          Show
          Kenney Westerhof added a comment - I have to agree with jason and john - keep the lifecycle small. About a year ago I started the maven-it-plugin, with the idea of using any standard lifecycle as a 'forked' sub-lifecycle. the 'integration-test' phase would run maven (embedded) on src/it/*/pom.xml, where each project could run any lifecycle they wish - by specifying a packaging. Normally you'd just have some tests in src/test/ which get executed. This way you can run multiple integration tests, without separate modules (unless you see src/it/* as modules). I think this, or something similar, is the way to go. We cannot simply grow the main lifecycle any time another usecase comes up. it's already too big - there should be just one integration-test phase; i don't even see the need for the pre- and post- phases there. It should be a hook to run a new lifecycle, like a subroutine. That should be flexible enough for anybody.
          Hide
          Nelz added a comment - - edited

          To Kenny:

          You convinced me. I really like the sound of the "maven-it-plugin"... It is much less 'literal' than the approach I was originally going with... Plus, it addresses my concerns about putting the tests for a war into a "second pass"...

          My only concern is this: MNG-1922 seemed to call into question the "maven-it-plugin" and it's functionality for testing anything outside of a Maven plugin... Is this still a problem/question?

          In the end, the "maven-it-plugin" sounds like it will scratch some itches I've been having. Is it in SVN, under https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk/? I'll start looking at that soon...

          Show
          Nelz added a comment - - edited To Kenny: You convinced me. I really like the sound of the "maven-it-plugin"... It is much less 'literal' than the approach I was originally going with... Plus, it addresses my concerns about putting the tests for a war into a "second pass"... My only concern is this: MNG-1922 seemed to call into question the "maven-it-plugin" and it's functionality for testing anything outside of a Maven plugin... Is this still a problem/question? In the end, the "maven-it-plugin" sounds like it will scratch some itches I've been having. Is it in SVN, under https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk/? I'll start looking at that soon...
          Hide
          brianfox brianfox added a comment -

          I think we've decided in the past not to add new phases, i'm tempted to close this but at a minimum it should go to 2.1

          Show
          brianfox brianfox added a comment - I think we've decided in the past not to add new phases, i'm tempted to close this but at a minimum it should go to 2.1
          Show
          Jason van Zyl added a comment - Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014
          Hide
          Jason van Zyl added a comment -

          Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014 if you're wondering why this issue was closed out.

          Show
          Jason van Zyl added a comment - Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014 if you're wondering why this issue was closed out.

            People

            • Assignee:
              Unassigned
              Reporter:
              Vincent Massol
            • Votes:
              12 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: