Building plugins with extensions in a reactor fails

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 2.0.1
  • Fix Version/s: 3.1
  • Component/s: Plugins and Lifecycle
  • Labels:
    None
  • Complexity:
    Intermediate

Description

I have the following in my main pom

<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.servicemix.plugins</groupId>
<artifactId>maven2-jbi-plugin</artifactId>
<version>1.0-SNAPSHOT</version>
<extensions>true</extensions>
</plugin>
</plugins>
</pluginManagement>
</build>

If i try to add it to the modules, the first time, maven complains that it can not download the plugin.
If i remove the <extensions> tag, all works, but i need it

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-1323 Plugin extensions (dependencies) not resolved in reactor build

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. MNG-656 lazily resolve extensions

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-1682 Plugins do not honor the correct extension when run as a part of a multiproject build

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. MNG-4081 Subtle case: Avoid resolving artifacts from outside the reactor for plugins and extensions whose projects are inside the reactor

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Casey added a comment -

so, how is the pluginManagement item getting triggered? Do you have the plugin referenced in the main part of your build in the main POM or something?

Show
John Casey added a comment - so, how is the pluginManagement item getting triggered? Do you have the plugin referenced in the main part of your build in the main POM or something?
Hide
Permalink
Brett Porter added a comment -

The current Geronimo build has the same problem. Order of build doesn't matter - it just needs to be used somewhere as the extensions are pre-loaded.

Workaround is to deploy a snapshot of the plugin so that Maven downloads the snapshot, uses that to load the extensions, builds the plugin, then reloads the new plugin when it is used.

Show
Brett Porter added a comment - The current Geronimo build has the same problem. Order of build doesn't matter - it just needs to be used somewhere as the extensions are pre-loaded. Workaround is to deploy a snapshot of the plugin so that Maven downloads the snapshot, uses that to load the extensions, builds the plugin, then reloads the new plugin when it is used.
Hide
Permalink
Jason Dillon added a comment -

Any status on when this will make it into a m2 release?

Show
Jason Dillon added a comment - Any status on when this will make it into a m2 release?
Hide
Permalink
Jason van Zyl added a comment -

John is this fixed now in trunk with your most recent build plan work?

Show
Jason van Zyl added a comment - John is this fixed now in trunk with your most recent build plan work?
Hide
Permalink
John Casey added a comment -

no, i haven't tested this use case with the new build plan. It may work, but I haven't tried yet.

Show
John Casey added a comment - no, i haven't tested this use case with the new build plan. It may work, but I haven't tried yet.
Hide
Permalink
Marvin Froeder added a comment -

Hi John,

Do you have any news on that?

Flex-mojos is suffering with this too.

VELO

Show
Marvin Froeder added a comment - Hi John, Do you have any news on that? Flex-mojos is suffering with this too. VELO
Hide
Permalink
Brett Porter added a comment -

This actually works on Maven 2.2.1, but seems to have regressed in 3.0-SNAPSHOT. Attaching the test program (artifacts must not be in the local repository for failure to appear), as I do not currently have time for a full IT/investigation.

Show
Brett Porter added a comment - This actually works on Maven 2.2.1, but seems to have regressed in 3.0-SNAPSHOT. Attaching the test program (artifacts must not be in the local repository for failure to appear), as I do not currently have time for a full IT/investigation.
Hide
Permalink
Benjamin Bentmann added a comment -

Until we extend the POM to allow to distinguish between different types of extensions in order to tell which of them can loaded sometime later during the build, there is no path forward.

Show
Benjamin Bentmann added a comment - Until we extend the POM to allow to distinguish between different types of extensions in order to tell which of them can loaded sometime later during the build, there is no path forward.
Hide
Permalink
Brett Porter added a comment -

putting into 3.1 so that such an extension to the POM can be made so that this can be made to work again

Show
Brett Porter added a comment - putting into 3.1 so that such an extension to the POM can be made so that this can be made to work again
Hide
Permalink
Brett Porter added a comment -

I didn't investigate enough originally, and the attached IT isn't complete to test this. This wasn't fixed in 2.2.1 - it doesn't actually load the extension, as it never ended up in the effective POM. Maven 3 now does that, and attempts to load the extension, which is not built.

The workaround to this, if suitable, is to use an older version of the plugin to use throughout the build.

Show
Brett Porter added a comment - I didn't investigate enough originally, and the attached IT isn't complete to test this. This wasn't fixed in 2.2.1 - it doesn't actually load the extension, as it never ended up in the effective POM. Maven 3 now does that, and attempts to load the extension, which is not built. The workaround to this, if suitable, is to use an older version of the plugin to use throughout the build.
Hide
Permalink
Lars Corneliussen added a comment -

Does anybody know what the concrete work would be to solve this issue? We struggle with this in NPanday...

Show
Lars Corneliussen added a comment - Does anybody know what the concrete work would be to solve this issue? We struggle with this in NPanday...
Hide
Permalink
Vincent Massol added a comment -

We really need this on the xwiki project too. Using an older version is not really a solution since when you make a change you need to use the latest version. We have some automated script to release XWiki which uses the maven release plugin and doing a 2 step release with the release plugin is really difficult (and probably impossible actually).

Show
Vincent Massol added a comment - We really need this on the xwiki project too. Using an older version is not really a solution since when you make a change you need to use the latest version. We have some automated script to release XWiki which uses the maven release plugin and doing a 2 step release with the release plugin is really difficult (and probably impossible actually).
Hide
Permalink
Robert Munteanu added a comment -

This also affects the Apache Sling build.

Show
Robert Munteanu added a comment - This also affects the Apache Sling build.

People

  • Assignee:
    Unassigned
    Reporter:
    Guillaume Nodet
Vote (9)
Watch (12)

Dates

  • Created:
    Updated: