Maven 2 & 3

Provide line number information when there are errors processing a pom.xml

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 3.0-beta-2
  • Component/s: Logging, POM
  • Labels:
    None
  • Environment:
    Maven 2.0, Windows xp, jdk 1.5, cygwin
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

When there is an error in a pom.xml, Maven 2 does a reasonable job identifying the error, but it doesn't provide the location of the error. For example, I forget to include a <version> inside one of my dependencies:

bash-3.00$ mvn
[INFO] Scanning for projects...
[INFO] ----------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ----------------------------------------------------------------------------
[INFO] Error building POM (may not be this project's POM).


Project ID: hivemind:hivemind
POM Location: c:\workspace\jakarta-hivemind\library\pom.xml
Validation Messages:

    [0]  'dependencies.dependency.version' is missing.


Reason: Failed to validate POM


[INFO] ----------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.reactor.MavenExecutionException: Failed to validate POM
        at org.apache.maven.DefaultMaven.getProjects(DefaultMaven.java:359)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:276)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:113)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:249)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)
        at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
        at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
        at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
        at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.project.InvalidProjectModelException: Failed to validate POM
        at org.apache.maven.project.DefaultMavenProjectBuilder.processProjectLogic(DefaultMavenProjectBuilder.java:774)
        at org.apache.maven.project.DefaultMavenProjectBuilder.build(DefaultMavenProjectBuilder.java:624)
        at org.apache.maven.project.DefaultMavenProjectBuilder.buildFromSourceFile(DefaultMavenProjectBuilder.java:298)
        at org.apache.maven.project.DefaultMavenProjectBuilder.build(DefaultMavenProjectBuilder.java:276)
        at org.apache.maven.DefaultMaven.getProject(DefaultMaven.java:509)
        at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:441)
        at org.apache.maven.DefaultMaven.getProjects(DefaultMaven.java:345)
        ... 11 more
[INFO] ----------------------------------------------------------------------------
[INFO] Total time: < 1 second
[INFO] Finished at: Sat Dec 10 10:09:16 PST 2005
[INFO] Final Memory: 1M/2M
[INFO] ----------------------------------------------------------------------------

Maven should have identified the LINE NUMBER, not just the file. I shouldn't have to pick my way though the document when Maven already has. Better yet, it should display the invalid portion of the file and highlight the exact point of the error.

I realize that it is controversial to add this issue as a bug and not an enhancement, but I feel strongly about the absolute importance of developer feedback in any complex tool.

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. MODELLO-240 Provide support to track line/column number of source elements

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jason van Zyl added a comment -

This is a lot better in 3.0, but we could still provide more assistance: currently it looks like this:

bash-3.2$ mvn validate
[INFO] Scanning for projects...
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR] The project org.apache.maven:maven-core:3.0-SNAPSHOT (/Users/jvanzyl/js/org/apache/maven/maven-3/trunk/maven-core/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' must be a valid version for commons-jxpath:commons-jxpath:jar but is '$

{jxpathVersion}

'.
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException

But we could add the line/column as well.

Show
Jason van Zyl added a comment - This is a lot better in 3.0, but we could still provide more assistance: currently it looks like this: bash-3.2$ mvn validate [INFO] Scanning for projects... [ERROR] The build could not read 1 project -> [Help 1] [ERROR] The project org.apache.maven:maven-core:3.0-SNAPSHOT (/Users/jvanzyl/js/org/apache/maven/maven-3/trunk/maven-core/pom.xml) has 1 error [ERROR] 'dependencies.dependency.version' must be a valid version for commons-jxpath:commons-jxpath:jar but is '$ {jxpathVersion} '. [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException But we could add the line/column as well.
Hide
Permalink
Jörg Buchberger added a comment -

Although, this seems somewhat addressed in these commits among others
r814330,13. September 2009
r824998,14. Oktober 2009
the Maven-3.0-SNAPSHOT included with m2eclipse-0.10.0.20100902-0800 won't give line and column information on the console output - e.g. for missing artifactId tag from a dependency. This is also true for invocations using the -e or -X options.

Although, there are some other hints about the error included with the output message, this enhancement seems very useful to me - especially, if I think of Maven newbies.

Perhaps, this would need to be also addressed in the org.apache.maven.settings.validation.DefaultSettingsValidator's addError() and addWarn() methods. But I don't know, the Maven codebase well, so this might be wrong as approach.

Show
Jörg Buchberger added a comment - Although, this seems somewhat addressed in these commits among others r814330,13. September 2009 r824998,14. Oktober 2009 the Maven-3.0-SNAPSHOT included with m2eclipse-0.10.0.20100902-0800 won't give line and column information on the console output - e.g. for missing artifactId tag from a dependency. This is also true for invocations using the -e or -X options. Although, there are some other hints about the error included with the output message, this enhancement seems very useful to me - especially, if I think of Maven newbies. Perhaps, this would need to be also addressed in the org.apache.maven.settings.validation.DefaultSettingsValidator's addError() and addWarn() methods. But I don't know, the Maven codebase well, so this might be wrong as approach.
Hide
Permalink
Benjamin Bentmann added a comment -

Added line/column information in r949708.

Show
Benjamin Bentmann added a comment - Added line/column information in r949708 .

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Howard M. Lewis Ship
Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: