Maven 2 & 3

Support in multiproject environment modules with different named POMs

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0.9, 3.0-alpha-1
  • Component/s: POM
  • Labels:
    None
  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Command line version of Maven 2 supports POMs with a different name using the -f option. Unfortunately such POMs cannot be used as modules, since the value of the module tag is defined as a directory to another pom.xml instead of a pathname to another POM. Only if the value is not already an existing file the value should be treated as directory with a present pom.xml file. Similar situation applies to the relativePath element of the parent tag.

This makes the generation of different artifacts from the same sources (with some modifications) much more easy. Currently you will have to put the POMs in separate directories and modify the sourec location into another module.

Issue Links

supercedes

Improvement - An improvement or enhancement to an existing feature or task. MNG-3150 Command line -f option should propagate to module poms.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Casey added a comment -

I thought this was already done, but we should verify. If not, it should be pretty easy to add it.

Show
John Casey added a comment - I thought this was already done, but we should verify. If not, it should be pretty easy to add it.
Hide
Permalink
Brett Porter added a comment -

this will require a change to the POM (reusing the existing modules entry would be too confusing, IMO). Putting back to 2.1.

Show
Brett Porter added a comment - this will require a change to the POM (reusing the existing modules entry would be too confusing, IMO). Putting back to 2.1.
Hide
Permalink
John Casey added a comment -

I was thinking I'd just allow a full specification of the relative pom-file path for modules, just like we allow the parent/relativePath to refer to a specific pom file location. It would actually improve the consistency of these path-based elements of the core POM (ie. not plugin configuration elements).

Show
John Casey added a comment - I was thinking I'd just allow a full specification of the relative pom-file path for modules, just like we allow the parent/relativePath to refer to a specific pom file location. It would actually improve the consistency of these path-based elements of the core POM (ie. not plugin configuration elements).
Hide
Permalink
Brett Porter added a comment -

sure, but that means we need to support an entry as either a directory or a pom file - won't that be too inconsistent?

Show
Brett Porter added a comment - sure, but that means we need to support an entry as either a directory or a pom file - won't that be too inconsistent?
Hide
Permalink
Jörg Schaible added a comment -

Why? If you specify a path only, "pom.xml" is simply the default. The relativePath element of the parent should behave in exactly the same way (docs seem to imply that you have to specify the pom.xml, the path alone will not do - despite the tag name).

Show
Jörg Schaible added a comment - Why? If you specify a path only, "pom.xml" is simply the default. The relativePath element of the parent should behave in exactly the same way (docs seem to imply that you have to specify the pom.xml, the path alone will not do - despite the tag name).
Hide
Permalink
Wendy Smoak added a comment -

Related thread http://www.nabble.com/Idea-for-%3Cmodules%3E-enhancement-t3880349s177.html

Show
Wendy Smoak added a comment - Related thread http://www.nabble.com/Idea-for-%3Cmodules%3E-enhancement-t3880349s177.html
Hide
Permalink
Brian Deacon added a comment -

Allows moduleFile to be treated as a file if it exists, rather than assuming pom.xml

Show
Brian Deacon added a comment - Allows moduleFile to be treated as a file if it exists, rather than assuming pom.xml
Hide
Permalink
John Casey added a comment -

applied patch, added integration test to verify the fix.

Thanks.

Show
John Casey added a comment - applied patch, added integration test to verify the fix. Thanks.
Hide
Permalink
Rollin Chen added a comment -

Here's an example for using alternative pom file in module
<modules>
<module>child/pom-jdk14.xml</module>
</modules>

Show
Rollin Chen added a comment - Here's an example for using alternative pom file in module <modules> <module>child/pom-jdk14.xml</module> </modules>

People

  • Assignee:
    John Casey
    Reporter:
    Jörg Schaible
Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: